Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux: add 'focusEvents' #6148

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

ambroisie
Copy link
Contributor

@ambroisie ambroisie commented Nov 28, 2024

With tmux-sensible being disabled by default (#6091), add an easy toggle to enable this functionality.

Disabled by default, as in upstream tmux (I could see an argument for enabling it by default, as sensibleOnTop was enabled by default and enabled this option unconditionally, but historically that's not been the way default option values have been chosen for this module).

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

@ambroisie
Copy link
Contributor Author

CI failure is on a Podman test.

With `tmux-sensible` being disabled by default, add an easy toggle to
enable this functionality.

Disabled by default, as in upstream `tmux`.
@rycee rycee force-pushed the tmux-focus-events branch from a784103 to bf23fe4 Compare December 2, 2024 21:44
@rycee rycee merged commit bf23fe4 into nix-community:master Dec 2, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented Dec 2, 2024

Thanks! Merged to master now 🙂

Perhaps it would be good to add a news entry about the removal of the sensible defaults plugin and how to recover various behaviors, such as using your new option?

@dbaynard
Copy link
Contributor

Perhaps it would be good to add a news entry about the removal of the sensible defaults plugin and how to recover various behaviors, such as using your new option?

Did this happen? I checked changlog entries and didn't clock anything. I'd be interested to know what else has been affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants