refactor recvmmsg lifetimes #2601
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into separate lifetimes for 'data, headers ('hdr) and related iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Currently
recvmmsguses a single lifetime to represent several different things:MultiHdrIoSliceMutIoSliceMutWhile correct this makes it impossible to reuse preallocated headers in a loop - modified test fails to compile without this change, but compiles and runs as expected after.
As for the actual reason - I suspect this is a bug in the borrow checker, at least this
RUSTFLAGS=-Zpolonius cargo +nightly checkfind no problems with modified test without requiring changes torecvmmsg.Hmm... And there's an unrelated formatting only commit - current formatting is wrong, but ignored by CI.
Checklist:
CONTRIBUTING.md