Skip to content

Mark nix::unistd::daemon unsafe and document why. #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark nix::unistd::daemon unsafe and document why. #2664

wants to merge 1 commit into from

Conversation

blp
Copy link

@blp blp commented Aug 22, 2025 •
edited
Loading

Fixes: #2663

What does this PR do

Marks nix::unstd::daemon unsafe and documents why.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@blp blp marked this pull request as ready for review August 22, 2025 21:24
@blp blp mentioned this pull request Aug 22, 2025
Open
asomers
asomers reviewed Aug 26, 2025
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware of any safety issues for single-threaded processes? I'm not. So i suggest we advise the user in the documentation that this function should only be used by single threaded processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix::unistd::daemon will kill all other threads
2 participants
@blp @asomers