chore: close sockets asap

nixpig · Dec 22, 2024 · 26fe386 · 26fe386
1 parent 0190876
commit 26fe386
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/container/container_reexec.go b/container/container_reexec.go
@@ -55,7 +55,7 @@ func (c *Container) Reexec() error {
 
 	initConn.Write([]byte("ready"))
 	// close asap so it doesn't leak into the container
-	defer initConn.Close()
+	initConn.Close()
 
 	// wait for "start"
 	if err := os.RemoveAll(
@@ -89,8 +89,8 @@ func (c *Container) Reexec() error {
 	}
 
 	// close as soon as we're done so they don't leak into the container
-	defer containerConn.Close()
-	defer listener.Close()
+	containerConn.Close()
+	listener.Close()
 
 	// after receiving "start"
 	if c.Spec.Process == nil {

diff --git a/container/container_start.go b/container/container_start.go
@@ -39,7 +39,7 @@ func (c *Container) Start() error {
 	if _, err := conn.Write([]byte("start")); err != nil {
 		return fmt.Errorf("send 'start' to container: %w", err)
 	}
-	defer conn.Close()
+	conn.Close()
 
 	c.SetStatus(specs.StateRunning)
 	if err := c.Save(); err != nil {