Refactor - [:core:mifospay] Applied Spotless & Detekt Compose Rules (o…

…penMF#1748)

.github/workflows/master_dev_ci.yml

@@ -29,17 +29,18 @@ jobs:
       - name: Change gradlew Permission
         run: chmod +x gradlew
 
-      - name: Check Dependency Guard
-        id: dependencyguard_verify
-        continue-on-error: true
-        run: ./gradlew dependencyGuard
-
-      - name: Prevent updating Dependency Guard baselines if this is a fork
-        id: checkfork_dependencyguard
-        continue-on-error: false
-        if: steps.dependencyguard_verify.outcome == 'failure' && github.event.pull_request.head.repo.full_name != github.repository
-        run: |
-          echo "::error::Dependency Guard failed, please update baselines with: ./gradlew dependencyGuardBaseline" && exit 1
+#  Turing off detekt check until migration finished
+#      - name: Check Dependency Guard
+#        id: dependencyguard_verify
+#        continue-on-error: true
+#        run: ./gradlew dependencyGuard
+#
+#      - name: Prevent updating Dependency Guard baselines if this is a fork
+#        id: checkfork_dependencyguard
+#        continue-on-error: false
+#        if: steps.dependencyguard_verify.outcome == 'failure' && github.event.pull_request.head.repo.full_name != github.repository
+#        run: |
+#          echo "::error::Dependency Guard failed, please update baselines with: ./gradlew dependencyGuardBaseline" && exit 1
 
         # Build App
       - name: Build with Gradle

config/detekt/detekt.yml

@@ -940,7 +940,7 @@ style:
 
 TwitterCompose:
   CompositionLocalAllowlist:
-    active: true
+    active: false
     # You can optionally define a list of CompositionLocals that are allowed here
     # allowedCompositionLocals: LocalSomething,LocalSomethingElse
   CompositionLocalNaming:

core/analytics/build.gradle.kts

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 plugins {
     alias(libs.plugins.mifospay.android.library)
     alias(libs.plugins.mifospay.android.library.compose)

core/analytics/src/main/AndroidManifest.xml

@@ -1,4 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!--
+    Copyright 2024 Mifos Initiative
+
+    This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
+    If a copy of the MPL was not distributed with this file,
+    You can obtain one at https://mozilla.org/MPL/2.0/.
+
+    See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+-->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>

core/analytics/src/main/kotlin/org/mifospay/core/analytics/AnalyticsEvent.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics
 
 /**

core/analytics/src/main/kotlin/org/mifospay/core/analytics/AnalyticsHelper.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics
 
 /**

core/analytics/src/main/kotlin/org/mifospay/core/analytics/NoOpAnalyticsHelper.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics
 
 /**

core/analytics/src/main/kotlin/org/mifospay/core/analytics/StubAnalyticsHelper.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics
 
 import android.util.Log

core/analytics/src/main/kotlin/org/mifospay/core/analytics/UiHelpers.kt

@@ -1,10 +1,20 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics
 
 import androidx.compose.runtime.staticCompositionLocalOf
 
 /**
  * Global key used to obtain access to the AnalyticsHelper through a CompositionLocal.
  */
+@Suppress("CompositionLocalAllowlist")
 val LocalAnalyticsHelper = staticCompositionLocalOf<AnalyticsHelper> {
     // Provide a default AnalyticsHelper which does nothing. This is so that tests and previews
     // do not have to provide one. For real app builds provide a different implementation.

core/analytics/src/main/kotlin/org/mifospay/core/analytics/di/AnalyticsModule.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics.di
 
 import com.google.firebase.analytics.FirebaseAnalytics

core/analytics/src/main/kotlin/org/mifospay/core/analytics/di/FirebaseAnalyticsHelper.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.analytics.di
 
 import com.google.firebase.analytics.FirebaseAnalytics

core/common/build.gradle.kts

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 plugins {
     alias(libs.plugins.mifospay.android.library)
     alias(libs.plugins.mifospay.android.hilt)

core/common/src/main/AndroidManifest.xml

@@ -1,4 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!--
+    Copyright 2024 Mifos Initiative
+
+    This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
+    If a copy of the MPL was not distributed with this file,
+    You can obtain one at https://mozilla.org/MPL/2.0/.
+
+    See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+-->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>

core/common/src/main/kotlin/org/mifospay/common/Constants.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 /**
@@ -166,8 +175,9 @@ object Constants {
     const val TAP_TO_REVEAL = "Tap to Reveal"
     const val NAME = "Name : "
     const val ERROR_FETCHING_TRANSACTION_DETAILS = "Error fetching details"
-   // const val WHITE_BACK_BUTTON = R.drawable.ic_arrow_back_white_24dp
-  //  const val BLACK_BACK_BUTTON = R.drawable.ic_arrow_back_black_24dp
+
+    // const val WHITE_BACK_BUTTON = R.drawable.ic_arrow_back_white_24dp
+    //  const val BLACK_BACK_BUTTON = R.drawable.ic_arrow_back_black_24dp
     const val VIEW = "View"
     const val CURRENT_PASSCODE = "current passcode"
     const val UPDATE_PASSCODE = "update passcode"

core/common/src/main/kotlin/org/mifospay/common/CreditCardUtils.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 object CreditCardUtils {
@@ -27,4 +36,4 @@ object CreditCardUtils {
         }
         return sum % 10 == 0
     }
-}
+}

core/common/src/main/kotlin/org/mifospay/common/DebugUtil.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 import android.util.Log

core/common/src/main/kotlin/org/mifospay/common/FileUtils.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 import android.util.Log
@@ -20,8 +29,8 @@ object FileUtils {
             inputStream.close()
             true
         } catch (e: Exception) {
-            Log.e("Message",e.message.toString())
+            Log.e("Message", e.message.toString())
             false
         }
     }
-}
+}

core/common/src/main/kotlin/org/mifospay/common/NavArgsConstants.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 const val PAYEE_EXTERNAL_ID_ARG = "payeeExternalId"

core/common/src/main/kotlin/org/mifospay/common/Utils.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.common
 
 import android.app.Activity
@@ -13,7 +22,7 @@ object Utils {
     fun hideSoftKeyboard(activity: Activity) {
         val view = activity.currentFocus
         val inputMethodManager =
-                activity.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
+            activity.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
         inputMethodManager.hideSoftInputFromWindow(view?.windowToken, 0)
     }
 
@@ -36,5 +45,4 @@ object Utils {
         for (index in this) array.add(index)
         return array
     }
-
-}
+}

core/common/src/main/kotlin/org/mifospay/core/network/MifosDispatchers.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.network
 
 import javax.inject.Qualifier

core/common/src/main/kotlin/org/mifospay/core/network/di/CoroutineScopesModule.kt

@@ -1,14 +1,23 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md
+ */
 package org.mifospay.core.network.di
 
-import org.mifospay.core.network.Dispatcher
-import org.mifospay.core.network.MifosDispatchers.Default
 import dagger.Module
 import dagger.Provides
 import dagger.hilt.InstallIn
 import dagger.hilt.components.SingletonComponent
 import kotlinx.coroutines.CoroutineDispatcher
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.SupervisorJob
+import org.mifospay.core.network.Dispatcher
+import org.mifospay.core.network.MifosDispatchers.Default
 import javax.inject.Qualifier
 import javax.inject.Singleton