Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Vitest #440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Vitest #440

wants to merge 1 commit into from

Conversation

matijs
Copy link
Member

@matijs matijs commented Feb 6, 2025

⚠️ test, do not le merge ⚠️

@matijs matijs added the do not merge Something that should not be merged just yet label Feb 6, 2025
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:04pm
candidate-storybook-non-conforming ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:04pm
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:04pm
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:04pm

Copy link

github-actions bot commented Feb 6, 2025

Uh oh! @sonarqubecloud[bot], at least one image you shared is missing helpful alt text. Check #440 (comment) to fix the following violations:

  • Images should have alternate text (alt text) at line 3
  • Images should have alternate text (alt text) at line 4
  • Images should have alternate text (alt text) at line 7
  • Images should have alternate text (alt text) at line 8
  • Images should have alternate text (alt text) at line 9

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

github-actions bot commented Feb 6, 2025

Uh oh! @sonarqubecloud[bot], at least one image you shared is missing helpful alt text. Check #440 (comment) to fix the following violations:

  • Images should have alternate text (alt text) at line 3
  • Images should have alternate text (alt text) at line 4
  • Images should have alternate text (alt text) at line 7
  • Images should have alternate text (alt text) at line 8
  • Images should have alternate text (alt text) at line 9

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (97bf917) to head (5bfd76c).

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #440      +/-   ##
===========================================
- Coverage   100.00%   99.47%   -0.53%     
===========================================
  Files           16       17       +1     
  Lines          391      382       -9     
  Branches        36       34       -2     
===========================================
- Hits           391      380      -11     
- Misses           0        1       +1     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbert
Copy link
Member

Robbert commented Feb 6, 2025

lgtm, ship it! 🚀

@matijs
Copy link
Member Author

matijs commented Feb 7, 2025

lgtm, ship it! 🚀

@Robbert Het is een piepklein PoCje maar begrijp ik dat je liever Vitest wilt dan Jest dus? Dan zal ik alle tests omkatten naar Vitest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Something that should not be merged just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants