Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deconstruct arguments applied to module #68

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

getchoo
Copy link
Contributor

@getchoo getchoo commented Feb 6, 2025

Fixes evaluate errors from #67 when cfg.package is not explicitly set or the overlay is not used

Sorry!

`lib.modules.importApply` applies an attribute set to it's given module,
not a single value
`lib.types.string` is deprecated
@nlewo nlewo merged commit fc4a395 into nlewo:main Feb 6, 2025
2 checks passed
@nlewo
Copy link
Owner

nlewo commented Feb 6, 2025

No problem.
Thanks for the quick fix.

(I should also add something to evaluate the module in the test suite.)

@getchoo getchoo deleted the fix-module branch February 6, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants