Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized and Debianized wordpress-formula #1

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

starchy
Copy link

@starchy starchy commented Apr 6, 2015

@nmadhok,

Here's a pull with a few big changes:

@@ -35,10 +35,11 @@ Formula Dependencies
====================

* `apache-formula <https://github.com/saltstack-formulas/apache-formula>`_
* `mysql-formula <https://github.com/saltstack-formulas/mysql-formula>`_
* `saltstack-mysql-formula <https://github.com/bechtoldt/saltstack-mysql-formula>`_
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an official saltstack formula. Please use official saltstack formula under https://github.com/saltstack-formulas/ or create a request to get the formula merged into saltstack-formulas.

@nmadhok
Copy link
Owner

nmadhok commented Apr 6, 2015

@starchy You are removing a lot of functionality from the formula on the RedHat/CentOS side. Any specific reason to do that? Have you tested this on RedHat environment as well? Have you tested this on Debian environment?

@starchy
Copy link
Author

starchy commented Apr 6, 2015

@nmadhok Hi, yes, this is tested on Debian. I wasn't aware of any functionality removed on the RHEL side - I thought I covered everything you had in parameters, but let me know if I missed something.

On 04/06/2015 03:20 PM, Nitin Madhok wrote:

@starchy https://github.com/starchy You are removing a lot of
functionality from the formula on the RedHat/CentOS side. Any specific
reason to do that? Have you tested this on RedHat environment as well?
Have you tested this on Debian environment?


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants