Move to arrow rs #3
Conversation
src/array/to_geoarrow.rs
Outdated
| .map(|v| v.map(Geometry::from)) | ||
| .collect::<Vec<_>>(), | ||
| )) | ||
| let mut builder = WKBBuilder::with_capacity(WKBCapacity::new(self.len(), self.len())); |
There was a problem hiding this comment.
btw, depending on the relative cost of repeated allocations to grow the wkb array vs the cost of materializing geometries from h3 objects, you may want to pre-calculate the exact capacities that you need for the WKBArray.
You can do that with WKBCapacity by calling add_polygon or from_polygons
There was a problem hiding this comment.
Thant you for your review - that is a good point. I tried to address this with 4dcf0ca
| impl_to_cells!(geoarrow::array::MultiLineStringArray<O>, O); | ||
| impl_to_cells!(geoarrow::array::MultiPointArray<O>, O); | ||
| impl_to_cells!(geoarrow::array::MultiPolygonArray<O>, O); | ||
| impl_to_cells!(geoarrow::array::PointArray); |
There was a problem hiding this comment.
Interesting! I've been wondering how to implement this! So far I've had separate hard-coded impls for PointArray https://github.com/geoarrow/geoarrow-rs/blob/3a2aaa883126274037cabaf46b1f5f6459938297/src/algorithm/geo/area.rs#L52-L63
I suppose this is slightly better, though you still have to duplicate the implementation in the macro.
There was a problem hiding this comment.
There still may be better ways to implement this. I just try to keep macro implementations not too complicated so I still understand them after coming back to them after a while ;)
| } | ||
| }) | ||
| self.get_as_geo(pos) | ||
| .map(|geom| geometry_to_cells(&geom, options)) |
There was a problem hiding this comment.
It would be awesome in the future — if we're able to standardize geometry traits — if h3o is able to implement conversions via those traits. Then you wouldn't have to go through geo objects for all these conversions.
There was a problem hiding this comment.
There is a lot of potential in the geometry traits. In the case of H3 cells it may be a bit complicated as these can be interpreted as polygons and points.
| @@ -33,9 +32,9 @@ where | |||
| opt.map(|array| { | |||
| array | |||
| .as_any() | |||
| .downcast_ref::<PrimitiveArray<u64>>() | |||
| .downcast_ref::<UInt64Array>() | |||
There was a problem hiding this comment.
btw you can use as_primitive if you want to save a few lines.
arrow2 is currently unmaintained: jorgecarleitao/arrow2#1429