Improvements on error handling in forecastio and instagram nodes #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some error checking to prevent referencing undefined medias object. Bumped version of instagram-node dependency to 0.5.8.
…r handling on non json api response
|
Hi, thanks for raising this. As described in our contribution guidelines, we need a signed contributor license agreement in place before we can merge a pull request. Nick |
|
node-red-gitbot: please update CLA status check |
|
Hi, I'm trying to get the tests to run with "istanbul cover grunt" as in the travis test but a lot of them are failing on nodes that haven't been touched in the commits. Is there anything special that I need to configure run to get the tests going? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instagram:
Forecastio: