Convert to ts #104
Closed
Convert to ts #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
U cray bro :D? |
|
I only understand trainstation. |
|
we can merge this, if you adapt to the newest version (i am freezing the code until then). |
- introduce fields - introduce basic types - all compilation errors are being ignored via @ts-ignore - this is more honest than some quirky any-type/casting - @ts-ignore may be fixed in a later step
|
Closing as upgrade was completed in #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential migration to typescript.
This should be no functional difference to the JS sources, as the typescript-conversion only touched imports and fields/properties for classes.
All other compilation-errors have been silenced via
@ts-ignore. They might indicate real bugs or just imprecise types, but can be addressed one-after-another. There's no need to fix all of them at once and thus a greater chance of bugs/unwanted changes.Future development can fully leverage typescript + type-definition are already generated.
Please let me know what you think about this PR.