Skip to content

chore(types): mirror https://github.com/nodejs/node/pull/58930 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2025

Conversation

avivkeller
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings July 3, 2025 14:17
@avivkeller avivkeller requested a review from a team as a code owner July 3, 2025 14:17
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (3c894dd) to head (07d2296).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   71.52%   71.55%   +0.02%     
==========================================
  Files         117      117              
  Lines        9719     9726       +7     
  Branches      590      590              
==========================================
+ Hits         6952     6959       +7     
  Misses       2764     2764              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns the MDN URL mappings with the referenced Node.js change by templating the ArrayBufferView link and introducing new Web API entries.

  • Replace a hardcoded ArrayBufferView URL with DOC_MDN_BASE_URL template
  • Add mappings for CloseEvent, EventSource, MessageEvent, DOMException, Storage, and WebSocket
Comments suppressed due to low confidence (2)

src/utils/parser/constants.mjs:362

  • Add unit tests for these newly added API mappings (CloseEvent, EventSource, MessageEvent, DOMException, Storage, WebSocket) to verify they resolve to the expected URLs.
  CloseEvent: `${DOC_MDN_BASE_URL}/API/CloseEvent`,

@ovflowd
Copy link
Member

ovflowd commented Jul 4, 2025

Let's only merge this once the upstream PR gets merged.

@avivkeller avivkeller enabled auto-merge (squash) July 4, 2025 16:30
@ovflowd ovflowd disabled auto-merge July 5, 2025 01:17
@ovflowd ovflowd merged commit f3b7097 into main Jul 5, 2025
9 checks passed
@ovflowd ovflowd deleted the chore/types/58930 branch July 5, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants