Skip to content

feat: use the regitry url of npm by default #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: use the regitry url of npm by default #656

wants to merge 6 commits into from

Conversation

zanminkian
Copy link

@zanminkian zanminkian commented Feb 13, 2025 •
edited
Loading

Closes #540
Closes #535

aduh95
aduh95 requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm might not be on the path, we can't assume it's going to work this way. Also, it would introduce quite a heavy perf penalty to any corepack command, even those which have nothing to do with npm or its registry.

@zanminkian
Copy link
Author

I will look into it in these few days.

@zanminkian zanminkian marked this pull request as draft February 17, 2025 04:33
@zanminkian zanminkian force-pushed the feat/registry_follow_npm branch from 635b244 to 9538922 Compare April 10, 2025 08:19
@zanminkian zanminkian mentioned this pull request Apr 10, 2025
Merged
@zanminkian zanminkian force-pushed the feat/registry_follow_npm branch 5 times, most recently from 9ac82c2 to e3bbdea Compare April 12, 2025 16:52
@zanminkian zanminkian force-pushed the feat/registry_follow_npm branch from e3bbdea to d29d556 Compare April 13, 2025 10:29
@zanminkian zanminkian marked this pull request as ready for review April 14, 2025 04:08
@zanminkian zanminkian requested a review from aduh95 April 14, 2025 04:10
@zanminkian zanminkian changed the title feat: COREPACK_NPM_REGISTRY defaults to the regitry of npm feat: use the regitry url of npm by default Apr 16, 2025
@zanminkian
Copy link
Author

zanminkian commented May 9, 2025 •
edited
Loading

There are many thumb-ups in #540, which means many people like this feature. Can someone help this PR move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: COREPACK_NPM_REGISTRY defaults to $(npm config get registry) cannot install pnpm
2 participants
@zanminkian @aduh95