Disables auto-pinning by default #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #552? |
I didn't see it before but yeah, same intent. It supersedes it though; it also updates the tests. |
|
I would appreciate this PR moving forward! Just yesterday I had to ask somebody to revert a commit because they had accidently added a Yarn Classic packageManager to a repo that uses npm as package manager. Removing the default auto-pinning would help prevent these sorts of mistakes. |
trivikr
reviewed
May 16, 2025
|
How to subscribe to publishing new versions? I want to upgrade as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe Corepack shouldn't have any negative impact on projects that aren't configured to use it. It should only be a net positive. Changing a file from the project has negative impacts as it leads to confusion ("why is this file changing?"), frustration ("I need to revert the file after every command!"), and sometimes breakages (pristine checks).
I didn't object much to auto-pinning at the time it was introduced because it was a request made by people from the TSC, and I was interested in compromise seeking. Considering the TSC declined to push Corepack further, I see less value in that and I'd like to revisit this design.
Fixes #485
Closes #552