Skip to content

feat(git-node): add support for promoting several releases at once #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 20, 2025

And from a different remote. Currently, the git node release --promote workflow doesn't work well for security releases as it assumes the release proposal exists on the same repo as where we want to make the release, and releases are to be released one-by-one.
This PR aims at addressing all this shortcomings.

The process is now roughly:

  1. for each proposal PR:
    1. Verify if it's ready (correct date, changelog entry, etc.).
    2. Create a signed tag for it.
    3. create a Working on … commit.
    4. rebase the public staging branch.
  2. checkout the default branch, and cherry-pick all releases commit on top of it.
  3. Print out a single git push command to push everything at once to the public repo.
  4. Rest of the workflow is not affected.

I've tested this with 24.1.0 and 22.16.0, seems to work fine!

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (197134f) to head (b19f363).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files          39       39           
  Lines        4630     4630           
=======================================
  Hits         3693     3693           
  Misses        937      937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 requested a review from RafaelGSS May 22, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant