test: add fast api tests for getLibuvNow()

nodejs · Nov 18, 2024 · 0c49cfb · 0c49cfb
1 parent f8c9ab4
commit 0c49cfb
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/src/timers.cc b/src/timers.cc
@@ -1,4 +1,7 @@
 #include "timers.h"
+
+#include <node_debug.h>
+
 #include "env-inl.h"
 #include "node_external_reference.h"
 #include "util-inl.h"
@@ -35,6 +38,7 @@ void BindingData::SlowGetLibuvNow(const FunctionCallbackInfo<Value>& args) {
 
 double BindingData::FastGetLibuvNow(Local<Object> unused,
                                     Local<Object> receiver) {
+  TRACK_V8_FAST_API_CALL("timers.getLibuvNow");
   return GetLibuvNowImpl(FromJSObject<BindingData>(receiver));
 }
 

diff --git a/test/parallel/test-timers-now.js b/test/parallel/test-timers-now.js
@@ -1,11 +1,28 @@
+// Flags: --expose-internals --no-warnings --allow-natives-syntax
 'use strict';
-// Flags: --expose-internals
 
-require('../common');
-const assert = require('assert');
+const common = require('../common');
+const assert = require('node:assert');
 const { internalBinding } = require('internal/test/binding');
 const binding = internalBinding('timers');
 
 // Return value of getLibuvNow() should easily fit in a SMI after start-up.
 // We need to use the binding as the receiver for fast API calls.
 assert(binding.getLibuvNow() < 0x3ffffff);
+
+{
+  // V8 Fast API
+  function testFastPaths() {
+    assert(binding.getLibuvNow() < 0x3ffffff);
+  }
+
+  eval('%PrepareFunctionForOptimization(binding.getLibuvNow)');
+  testFastPaths();
+  eval('%OptimizeFunctionOnNextCall(binding.getLibuvNow)');
+  testFastPaths();
+
+  if (common.isDebug) {
+    const { getV8FastApiCallCount } = internalBinding('debug');
+    assert.strictEqual(getV8FastApiCallCount('timers.getLibuvNow'), 1);
+  }
+}