Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x backport] process: add process.ref() and process.unref() methods #56571

Merged
merged 3 commits into from
Feb 4, 2025
Merged

[v22.x backport] process: add process.ref() and process.unref() methods #56571

merged 3 commits into from
Feb 4, 2025
+118 −0

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 12, 2025

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jan 12, 2025
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64947/

jasnell and others added 3 commits February 4, 2025 10:14
@jasnell @aduh95
process: add process.ref() and process.unref() methods
396a830 
The `process.ref(...)` and `process.unref(...)` methods are intended
to replace the use of `ref()` and `unref()` methods defined directly
on individual API objects. The existing `ref()` and `unref()` methods
will be marked as legacy and won't be removed but new APIs should use
`process.ref()` and `process.unref()` instead.

Refs: nodejs#53266
PR-URL: nodejs#56400
Backport-PR-URL: nodejs#56571
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@aduh95
process: fix symbol key and mark experimental new node:process methods
499a5cb 
PR-URL: nodejs#56517
Backport-PR-URL: nodejs#56571
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95
process: remove support for undocumented symbol
6ad8990 
PR-URL: nodejs#56552
Backport-PR-URL: nodejs#56571
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 force-pushed the backport-unref-ref branch from 390e8fa to 6ad8990 Compare February 4, 2025 09:15
@aduh95 aduh95 merged commit 6ad8990 into nodejs:v22.x-staging Feb 4, 2025
19 of 21 checks passed
@aduh95 aduh95 deleted the backport-unref-ref branch February 4, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @jasnell @anonrig