test_runner: print formatted errors on summary #56911
Merged
+111
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
commented
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56911 +/- ##
==========================================
+ Coverage 89.16% 89.18% +0.02%
==========================================
Files 665 665
Lines 192602 192555 -47
Branches 37050 37050
==========================================
Hits 171732 171732
+ Misses 13678 13632 -46
+ Partials 7192 7191 -1
|
pmarchini
force-pushed
the
issue/56902
branch
from
72e82e9 to
9e21914
Compare
cjihrig
reviewed
Feb 4, 2025
cjihrig
approved these changes
Feb 5, 2025
cjihrig
added
dont-land-on-v18.x
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pmarchini
added
the
author ready
atlowChemi
approved these changes
Feb 9, 2025
jasnell
approved these changes
Feb 9, 2025
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56911 ✔ Done loading data for nodejs/node/pull/56911 ----------------------------------- PR info ------------------------------------ Title test_runner: print formatted errors on summary (#56911) Author Pietro Marchini <[email protected]> (@pmarchini) Branch pmarchini:issue/56902 -> nodejs:main Labels author ready, needs-ci, dont-land-on-v18.x, test_runner, dont-land-on-v20.x Commits 2 - test_runner: print formatted errors on summary - test_runner: avoid unnecessary variable declaration Committers 1 - Pietro Marchini <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Feb 2025 09:37:33 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56911#pullrequestreview-2596108820 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/56911#pullrequestreview-2604322740 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56911#pullrequestreview-2604324168 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-06T11:18:17Z: https://ci.nodejs.org/job/node-test-pull-request/65029/ - Querying data for job/node-test-pull-request/65029/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 56911 From https://github.com/nodejs/node * branch refs/pull/56911/merge -> FETCH_HEAD ✔ Fetched commits as d1f8ccb10dab..666cb91c6964 -------------------------------------------------------------------------------- [main f0416a0650] test_runner: print formatted errors on summary Author: Pietro Marchini <[email protected]> Date: Tue Feb 4 13:50:52 2025 +0100 4 files changed, 112 insertions(+), 19 deletions(-) create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.mjs create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.snapshot [main 3557f27e18] test_runner: avoid unnecessary variable declaration Author: Pietro Marchini <[email protected]> Date: Tue Feb 4 21:51:50 2025 +0100 1 file changed, 1 insertion(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: print formatted errors on summaryhttps://github.com/nodejs/node/actions/runs/13228205767 |
cjihrig
removed
the
commit-queue-failed
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a2aa6ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this discussion: #56662 (comment)
This PR should address #56902