-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x backport] typescript syntax detection #56912
Open
marco-ippolito
wants to merge
9
commits into
nodejs:v22.x-staging
Choose a base branch
from
marco-ippolito:backport-typescript
base: v22.x-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[v22.x backport] typescript syntax detection #56912
marco-ippolito
wants to merge
9
commits into
nodejs:v22.x-staging
from
marco-ippolito:backport-typescript
+930
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
v22.x
v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
labels
Feb 4, 2025
PR-URL: nodejs#56285 Refs: nodejs/typescript#17 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: nodejs#56359 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: nodejs#56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#56358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#56394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
PR-URL: nodejs#56610 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: nodejs#56646 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
force-pushed
the
backport-typescript
branch
from
February 4, 2025 14:59
6504a2f
to
dc85212
Compare
aduh95
changed the title
[v22.x] backport typescript syntax detection
[v22.x backport] typescript syntax detection
Feb 4, 2025
aduh95
reviewed
Feb 4, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
strip-types
Issues or PRs related to strip-types support
v22.x
v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of some PRs:
As requested @aduh95