Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove obsolete NoArrayBufferZeroFillScope #56913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: remove obsolete NoArrayBufferZeroFillScope #56913

wants to merge 1 commit into from
+0 −23

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 4, 2025

No longer used or necessary

@jasnell jasnell requested review from anonrig and aduh95 February 4, 2025 13:30
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 4, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (dd92abc) to head (dfb451a).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56913      +/-   ##
==========================================
+ Coverage   89.20%   89.21%   +0.01%     
==========================================
  Files         665      665              
  Lines      192498   192498              
  Branches    37046    37052       +6     
==========================================
+ Hits       171710   171745      +35     
- Misses      13601    13605       +4     
+ Partials     7187     7148      -39
Files with missing lines Coverage Δ
src/env-inl.h 96.94% <ø> (ø)
src/env.h 98.14% <ø> (ø)

... and 38 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64987/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @addaleax @targos @legendecas @aduh95