module: prevent crashes in require.resolve() when path is not a string #56942
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56942 +/- ##
==========================================
- Coverage 89.17% 89.15% -0.03%
==========================================
Files 665 665
Lines 192554 192853 +299
Branches 37064 37151 +87
==========================================
+ Hits 171710 171929 +219
- Misses 13645 13695 +50
- Partials 7199 7229 +30
|
jasnell
reviewed
Feb 7, 2025
jasnell
approved these changes
Feb 7, 2025
Aditi-1400
force-pushed
the
issue-47698
branch
from
037065d to
3b4e551
Compare
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Feb 7, 2025
aduh95
added
the
author ready
lpinca
approved these changes
Feb 7, 2025
jsumners-nr
approved these changes
Feb 7, 2025
|
@Aditi-1400 Can you wrap the commit message by 72 characters? https://github.com/nodejs/node/actions/runs/13198267230/job/36844336252?pr=56942 |
Aditi-1400
force-pushed
the
issue-47698
branch
from
3b4e551 to
8c80bb8
Compare
This was referenced Feb 7, 2025
Previously, `require.resolve()` could crash when: - The first parameter was a relative path and - The `paths` array contained non-string entries This commit fixes the issue by adding a check in `Module._findPath` to ensure all elements in `paths` are strings, and adding a validation in `stat` before calling `InternalModuleStat` to guard against non-string filenames.
Aditi-1400
force-pushed
the
issue-47698
branch
from
8c80bb8 to
ba86f84
Compare
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47698
Previously,
require.resolve()would crash when:pathsarray contained non-string entriesThis commit fixes the issue by adding a check in
Module._findPathto ensure all elements inpathsare strings, and adding a validation instatbefore callingInternalModuleStatto guard against non-string filenames.