sqlite: fix coverity warnings related to backup() #56961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes several coverity warnings related to the recently landed backup() API.
nodejs-github-bot
added
c++
targos
approved these changes
Feb 8, 2025
anonrig
approved these changes
Feb 8, 2025
anonrig
added
author ready
jasnell
approved these changes
Feb 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56961 +/- ##
=======================================
Coverage 89.13% 89.14%
=======================================
Files 665 665
Lines 193165 193172 +7
Branches 37191 37191
=======================================
+ Hits 172181 172201 +20
+ Misses 13729 13728 -1
+ Partials 7255 7243 -12
|
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
jasnell
added
the
commit-queue
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
removed
the
commit-queue
|
Landed in 72e1a8f |
targos
pushed a commit
that referenced
this pull request
Feb 11, 2025
This commit fixes several coverity warnings related to the recently landed backup() API. PR-URL: #56961 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several coverity warnings related to the recently landed backup() API.