sqlite,test,doc: accept Buffer and URL as paths #56991
Open
+224
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
sqlite-accept-buffer
branch
from
446d48b to
18fe76b
Compare
geeksilva97
force-pushed
the
sqlite-accept-buffer
branch
3 times, most recently
from
2a608e1 to
5b5a8cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56991 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.01%
==========================================
Files 629 629
Lines 184308 184407 +99
Branches 36010 36029 +19
==========================================
+ Hits 166544 166619 +75
+ Misses 10910 10907 -3
- Partials 6854 6881 +27
|
geeksilva97
force-pushed
the
sqlite-accept-buffer
branch
4 times, most recently
from
06d30bf to
4561203
Compare
geeksilva97
commented
Feb 21, 2025
geeksilva97
changed the title
geeksilva97
commented
Feb 21, 2025
geeksilva97
commented
Feb 21, 2025
cjihrig
reviewed
Feb 21, 2025
geeksilva97
force-pushed
the
sqlite-accept-buffer
branch
from
303de33 to
7019435
Compare
geeksilva97
commented
Feb 21, 2025
cjihrig
reviewed
Feb 22, 2025
geeksilva97
commented
Feb 24, 2025
| url->Get(env->context(), env->protocol_string()).ToLocal(&protocol) && | ||
| protocol->IsString()) { | ||
| location = Utf8Value(env->isolate(), href.As<String>()).ToString(); | ||
| if (!has_null_bytes(location)) { |
There was a problem hiding this comment.
Checking for null bytes here but when using new URL it deals with that already.
geeksilva97
force-pushed
the
sqlite-accept-buffer
branch
from
07a5b31 to
114df4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56940
This PR adds the capability to the sqlite module to accept Buffer and URL as the database location.