Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: buffer.indexOf: add more number cases #57200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Feb 24, 2025

add some more cases that assert the success result is relative to the start of the Buffer and not the byteOffset parameter
existing number cases only checked 0 and -1 returns

discovered by oven-sh/bun#17555

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (22ac597) to head (8edf69e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57200   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         630      630           
  Lines      184513   184513           
  Branches    36073    36071    -2     
=======================================
+ Hits       166644   166647    +3     
+ Misses      10962    10959    -3     
  Partials     6907     6907           

see 33 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants