Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025-02-26, Version 23.9.0 (Current) #57207

Open
wants to merge 92 commits into
base: v23.x
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

2025-02-26, Version 23.9.0 (Current), @targos

Notable Changes

  • [927d985aa0] - (SEMVER-MINOR) dns: add TLSA record query and parsing (Rithvik Vibhu) #52983
  • [0236fbf75a] - (SEMVER-MINOR) process: add threadCpuUsage (Paolo Insogna) #56467

Commits

  • [f4a82fddb1] - benchmark: add a warmup on bench-openSync (Elves Vieira) #57051
  • [d6111eaf8b] - build: print 'Formatting Markdown...' for long task markdown formatting (1ilsang) #57108
  • [922ea2f8c7] - build: add skip_apidoc_files and include QUIC (RafaelGSS) #56941
  • [5af35d1850] - build: fix GN build failure (Cheng) #57013
  • [35f89aa66f] - build: fix GN build of uv (Cheng) #56955
  • [891a23975c] - cli: allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
  • [b50fc42a99] - crypto: support --use-system-ca on non-Windows and non-macOS (Joyee Cheung) #57009
  • [dfdaa92a37] - crypto: fix missing OPENSSL_NO_ENGINE guard (Shelley Vohr) #57012
  • [18ea88bcbe] - crypto: cleanup root certificates and skip PEM deserialization (Joyee Cheung) #56999
  • [30000f7b22] - deps: update cjs-module-lexer to 2.1.0 (Node.js GitHub Bot) #57180
  • [552bc7bd57] - deps: update ngtcp2 to 1.11.0 (Node.js GitHub Bot) #57179
  • [b809db09bf] - deps: update sqlite to 3.49.1 (Node.js GitHub Bot) #57178
  • [ac0f18e09f] - deps: update ada to 3.1.0 (Node.js GitHub Bot) #57083
  • [927d985aa0] - (SEMVER-MINOR) dns: add TLSA record query and parsing (Rithvik Vibhu) #52983
  • [d7cc014de0] - doc: update options to filehandle.appendFile() (Hasegawa-Yukihiro) #56972
  • [5cf36a04a4] - doc: add additional caveat for fs.watch (Michael Dawson) #57150
  • [f399d50d0f] - doc: fix typo in Windows building instructions (Tim Jacomb) #57158
  • [fb15c404bc] - doc: fix web.libera.chat link in pull-requests.md (Samuel Bronson) #57076
  • [ca651063c0] - doc: remove buffered flag from performance hooks examples (Pavel Romanov) #52607
  • [ba84b6765d] - doc: fix 'introduced_in' version in typescript module (1ilsang) #57109
  • [6cf207e13b] - doc: fix link and history of SourceMap sections (Antoine du Hamel) #57098
  • [d978aeee4b] - doc: add module namespace object links (Dario Piotrowicz) #57093
  • [51adbd5c72] - doc: disambiguate pseudo-code statement (Dario Piotrowicz) #57092
  • [4eec167da0] - doc: update clang-cl on Windows building guide (Joyee Cheung) #57087
  • [0762086b0b] - doc: update Xcode version used for arm64 and pkg (Michaël Zasso) #57104
  • [efd2202529] - doc: fix wrong articles used to address modules (Dario Piotrowicz) #57090
  • [ed5671f1bc] - doc: update module.builtinModules sentence (Dario Piotrowicz) #57089
  • [9de45cbac9] - doc: modules.md: fix distance definition (Alexander “weej” Jones) #57046
  • [a7e5ef9e01] - doc: fix wrong verb form (Dario Piotrowicz) #57091
  • [c02494f5fe] - doc: fix transpiler loader hooks documentation (Joyee Cheung) #57037
  • [5b2dfadd40] - doc: add a note about require('../common') in testing documentation (Aditi) #56953
  • [50ba04e214] - doc: recommend writing tests in new files and including comments (Joyee Cheung) #57028
  • [6951133e1a] - doc: improve documentation on argument validation (Aditi) #56954
  • [44dd8a5cc2] - doc: buffer: fix typo on Buffer.copyBytesFrom( offset option (tpoisseau) #57015
  • [c011271a70] - doc: update cleanup to trust on vuln db automation (Rafael Gonzaga) #57004
  • [a6b7bce3a0] - doc: move stability index after history section for consistency (Antoine du Hamel) #56997
  • [3bc6d626b4] - doc: add signal to filehandle.writeFile() options (Yukihiro Hasegawa) #56804
  • [2990cc8616] - doc: run license-builder (github-actions[bot]) #56985
  • [40f3a516bf] - fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided (Juan José Arboleda) #56996
  • [347043dc0a] - inspector: convert event params to protocol without json (Chengzhong Wu) #57027
  • [3bb60a30d5] - inspector: skip promise hook in the inspector async hook (Joyee Cheung) #57148
  • [b526165449] - lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses (James M Snell) #57177
  • [590f7024c7] - lib: fixup incorrect argument order in assertEncoding (James M Snell) #57177
  • [d09439a76a] - meta: bump actions/setup-python from 5.3.0 to 5.4.0 (dependabot[bot]) #56867
  • [3ea44e44aa] - meta: bump peter-evans/create-pull-request from 7.0.5 to 7.0.6 (dependabot[bot]) #56866
  • [f48945df6f] - meta: bump mozilla-actions/sccache-action from 0.0.6 to 0.0.7 (dependabot[bot]) #56865
  • [950a8c722b] - meta: bump codecov/codecov-action from 5.0.7 to 5.3.1 (dependabot[bot]) #56864
  • [ea0ebf611f] - meta: bump step-security/harden-runner from 2.10.2 to 2.10.4 (dependabot[bot]) #56863
  • [5002b66add] - meta: bump actions/cache from 4.1.2 to 4.2.0 (dependabot[bot]) #56862
  • [0d89c99dbe] - meta: bump actions/stale from 9.0.0 to 9.1.0 (dependabot[bot]) #56860
  • [894f0aae66] - meta: bump github/codeql-action from 3.27.5 to 3.28.8 (dependabot[bot]) #56859
  • [47b4696d28] - meta: add CODEOWNERS for SQLite (Colin Ihrig) #57147
  • [2ec4ff17a6] - meta: update last name for jkrems (Jan Martin) #57006
  • [be76b44928] - module: improve error message from asynchronicity in require(esm) (Joyee Cheung) #57126
  • [d5a994ced1] - module: allow omitting context in synchronous next hooks (Joyee Cheung) #57056
  • [0236fbf75a] - (SEMVER-MINOR) process: add threadCpuUsage (Paolo Insogna) #56467
  • [bc296a4aa1] - process: remove support for undocumented symbol (Antoine du Hamel) #56552
  • [f2db69a08f] - sea: suppress builtin warning with disableExperimentalSEAWarning option (koooge) #57086
  • [456445664a] - src: fix crash when lazy getter is invoked in a vm context (Chengzhong Wu) #57168
  • [5c0742abab] - src: do not format single string argument for THROW_ERR_* (Joyee Cheung) #57126
  • [eaead6f8a0] - src: gate all quic behind disabled-by-default compile flag (James M Snell) #57142
  • [0f6895fecb] - src: move instead of copy shared pointer in node_blob (Michaël Zasso) #57120
  • [f590ad9acf] - src: replace NewFromUtf8 with OneByteString where appropriate (James M Snell) #57096
  • [452463f09c] - src: port defineLazyProperties to native code (Antoine du Hamel) #57081
  • [47ddf5529f] - src: improve error handling in node_blob (James M Snell) #57078
  • [899890b20f] - src: improve error handling in multiple files (James M Snell) #56962
  • [286bb84188] - src: fix accessing empty string (Cheng) #57014
  • [fa26f83e5b] - src: lock the isolate properly in IsolateData destructor (Joyee Cheung) #57031
  • [7e2dac9fcc] - src: add self-assigment memcpy checks (Burkov Egor) #56986
  • [d8e70dcaa6] - src: improve node::Dotenv trimming (Dario Piotrowicz) #56983
  • [41f444fa78] - src: improve error handling in string_bytes/decoder (James M Snell) #56978
  • [d0ee8c0a20] - src: improve error handling in process_wrap (James M Snell) #56977
  • [a751addc86] - test: add doAppendAndCancel test (Hasegawa-Yukihiro) #56972
  • [d41952bafe] - test: fix test-without-async-context-frame.mjs in debug mode (Joyee Cheung) #57034
  • [0ea92cef0b] - test: make eval snapshot comparison more flexible (Shelley Vohr) #57020
  • [2d860e602e] - test: simplify test-http2-client-promisify-connect-error (Luigi Pinca) #57144
  • [8e3de98c3b] - test: improve error output of test-http2-client-promisify-connect-error (Antoine du Hamel) #57135
  • [a588066518] - test: add case for unrecognised fields within pjson "exports" (Jacob Smith) #57026
  • [b369ad6e45] - test: remove unnecessary assert requiring from tests (Dario Piotrowicz) #57008
  • [9b98ac6a81] - test: update WPT for urlpattern to ef6d83d789 (Node.js GitHub Bot) #56984
  • [0a82d27d28] - test: reduce flakiness on test-net-write-fully-async-buffer (Yagiz Nizipli) #56971
  • [ab150d7781] - test: remove flakiness on macOS test (Yagiz Nizipli) #56971
  • [ccb8c12712] - test,crypto: make tests work for BoringSSL (Shelley Vohr) #57021
  • [2abffd40de] - test_runner: refactor testPlan counter increse (Pietro Marchini) #56765
  • [a424c15827] - test_runner: allow special characters in snapshot keys (Carlos Espa) #57017
  • [ebacbf8d2b] - tools: run Linux tests on GitHub arm64 runners as well (Dennis Ameling) #57162
  • [07249bf2df] - tools: consolidate 'introduced_in' check for docs (1ilsang) #57109
  • [6cdee545f6] - tools: do not run major-release workflow on forks (Rich Trott) #57064
  • [1efd74b1b0] - tools: fix release URL computation in update-root-certs.mjs (Joyee Cheung) #56843
  • [a9112df8d3] - tools: add support for import source syntax in linter (Antoine du Hamel) #56992
  • [e8c5acf873] - typings: fix ImportModuleDynamicallyCallback return type (Chengzhong Wu) #57160
  • [5997393521] - url: improve urlpattern regexp performance (Yagiz Nizipli) #57136

anonrig and others added 30 commits February 17, 2025 10:45
Replace ToLocalChecked uses.

PR-URL: #56977
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
the trimming functionality that the dotenv parsing uses currently
only takes into consideration plain spaces (' '), other type of
space characters such as tabs and newlines are not trimmed, this
can cause subtle bugs, so the changes here make sure that such
characters get trimmed as well

Co-authored-by: Yagiz Nizipli <[email protected]>
PR-URL: #56983
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #56984
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56985
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #56955
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #56804
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Fixes: #56718
PR-URL: #56986
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #56997
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Since nodejs-private/security-release#56 this
process has been automated.

PR-URL: #57004
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
- We do not actually need them in PEM format, so just pass them
  around as X509 direcrtly.
- The cached global X509 structures were previously never cleaned
  up. Clean them up at process teardown.
- Use function-local static to ensure thread-safety in
  initialization.
- Add more comments about how the various options differ.

PR-URL: #56999
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Also adds current work email to mailmap.

PR-URL: #57006
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Previously this would compute the release tag to be something
like FIREFOX_134_0.2_RELEASE which would not lead to a valid
URL, failing to pull the latest NSS updates from the Firefox
release. It should replace all the dots with underscores to
compute something like FIREFOX_134_0_2_RELEASE instead.

PR-URL: #56843
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #57015
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #56954
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #57008
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ref #56559

PR-URL: #57021
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #57013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
The previous phrasing encouraged or did not discourage appending
new test cases to existing files - a practice that can reduce
the debuggability of the tests over time as they get bigger and
bigger, some times thousands of lines long with hundreds of
test cases, and make the CI output increasingly difficult to
read when one of the test cases fail in a very long test.

This patch updates the guideline to explicitly discourage appending
test cases this way. Also recommend including an opening comment
to describe what the test does to optimize the test towards the
scenario when it fails.

PR-URL: #57028
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
PR-URL: #57064
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57026
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #56993
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
On other platforms, load from the OpenSSL default certificate
file and diretory.
This is different from --use-openssl-ca in that it caches
the certificates on first load, instead of always reading
from disk every time a new root store is needed.

When used together with the statically-linked OpenSSL, the
default configuration usually leads to this behavior:

- If SSL_CERT_FILE is used, load from SSL_CERT_FILE. Otherwise
  load from /etc/ssl/cert.pem
- If SSL_CERT_DIR is used, load from all the files under
  SSL_CERT_DIR. Otherwise, load from all the files under
  /etc/ssl/certs

PR-URL: #57009
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Otherwise it may fail the DCHECK that uses the locked thread
as a fast path to get the current thread.

PR-URL: #57031
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #57014
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
dependabot bot and others added 24 commits February 25, 2025 17:51
Bumps [actions/cache](https://github.com/actions/cache) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@6849a64...1bd1e32)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56862
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.2 to 2.10.4.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@0080882...cb605e5)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56863
Reviewed-By: Luigi Pinca <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.0.7 to 5.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@015f24e...13ce06b)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56864
Reviewed-By: Luigi Pinca <[email protected]>
Bumps [mozilla-actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.6 to 0.0.7.
- [Release notes](https://github.com/mozilla-actions/sccache-action/releases)
- [Commits](Mozilla-Actions/sccache-action@v0.0.6...054db53)

---
updated-dependencies:
- dependency-name: mozilla-actions/sccache-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56865
Reviewed-By: Luigi Pinca <[email protected]>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@5e91468...67ccf78)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56866
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@0b93645...4237552)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56867
Reviewed-By: Luigi Pinca <[email protected]>
Instead of filtering out promises in the async hooks added
for async task tracking, add an internal path to skip adding
the promise hook completely for the inspector async hook.
The actual user-land promise tracking is already handled by
V8 inspector. This prevents the internal promise hook from
showing up and creating unnecessary noise when stepping into
async execution in the inspector.

PR-URL: #57148
Refs: https://issues.chromium.org/issues/390581540
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: #57162
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!

PR-URL: #57076
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
The test is spawning the python test runner directly without
considering whether the current build is a debug build or not
i.e. does not propage the mode parameter when the test is
run with --mode=debug, so it always ends up using the release
build to run the test even if the test is being run for debug
builds. This patch fixes that.

PR-URL: #57034
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56765
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #57158
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Event params object can be converted to inspector protocol directly.
This also enables binary data, like `Network.dataReceived`, to be sent
in the inspector protocol from JavaScript since JSON representation
does not support plain binary data.

PR-URL: #57027
Reviewed-By: Kohei Ueno <[email protected]>
Add clarification based on discussion with security
researcher.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57150
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57177
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57177
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57178
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: #57179
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #57180
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Notable changes:

dns:
  * (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
process:
  * (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467

PR-URL: #57207
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2025
@targos targos marked this pull request as ready for review February 25, 2025 16:56
@targos targos removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 25, 2025

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 66.27451% with 344 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (196efd7) to head (9d2368f).
Report is 1 commits behind head on v23.x.

Files with missing lines Patch % Lines
src/inspector/network_agent.cc 54.83% 32 Missing and 38 partials ⚠️
src/crypto/crypto_context.cc 40.95% 53 Missing and 9 partials ⚠️
src/cares_wrap.cc 25.75% 46 Missing and 3 partials ⚠️
src/process_wrap.cc 41.25% 24 Missing and 23 partials ⚠️
src/node_serdes.cc 53.84% 16 Missing and 8 partials ⚠️
src/node_util.cc 63.63% 8 Missing and 12 partials ⚠️
src/node_process_object.cc 65.62% 5 Missing and 6 partials ⚠️
lib/internal/modules/esm/loader.js 59.09% 9 Missing ⚠️
src/node_blob.cc 64.00% 6 Missing and 3 partials ⚠️
src/node_messaging.cc 76.66% 3 Missing and 4 partials ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #57207      +/-   ##
==========================================
+ Coverage   89.14%   90.30%   +1.15%     
==========================================
  Files         665      627      -38     
  Lines      193114   183828    -9286     
  Branches    37193    35897    -1296     
==========================================
- Hits       172156   166005    -6151     
+ Misses      13685    10979    -2706     
+ Partials     7273     6844     -429     
Files with missing lines Coverage Δ
lib/async_hooks.js 99.66% <100.00%> (+<0.01%) ⬆️
lib/inspector.js 96.72% <100.00%> (+0.44%) ⬆️
lib/internal/async_hooks.js 99.36% <100.00%> (+<0.01%) ⬆️
lib/internal/bootstrap/node.js 99.57% <100.00%> (+<0.01%) ⬆️
lib/internal/bootstrap/web/exposed-wildcard.js 100.00% <100.00%> (+0.86%) ⬆️
lib/internal/dns/utils.js 99.44% <100.00%> (+<0.01%) ⬆️
lib/internal/errors.js 97.42% <100.00%> (-0.05%) ⬇️
lib/internal/fs/utils.js 99.69% <100.00%> (ø)
lib/internal/fs/watchers.js 85.78% <100.00%> (ø)
lib/internal/inspector_async_hook.js 100.00% <100.00%> (ø)
... and 50 more

... and 89 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.