WSL guidance on download page #7757
Conversation
… utils Moved downloadConstants.json and downloadUtils.tsx into a dedicated subdirectory. Removed redundant UserOs array and now infer it dynamically from OperatingSystemLabel keys. Fixes: nodejs#7561 Signed-off-by: vishal <[email protected]>
… utils Moved constants.json and index.tsx into a dedicated subdirectory. Reorganized constants such as PLATFORMS into constants.json using object destructuring. Refactored INSTALL_METHODS to use object destructuring and removed explicit any types. Similarly for OS_NOT_SUPPORTING_INSTALLERS, OperatingSystems Fixes: nodejs#7561 Signed-off-by: vishal <[email protected]>
- Move package managers configuration to constants.json - Refactor icon handling to use dynamic component mapping - Remove redundant installMethodIconsMap - Standardize icon handling across OS, package managers, and install methods - Clean up imports and destructuring from constants.json This change improves code maintainability by: - Centralizing configuration in constants.json - Using consistent patterns for icon handling - Reducing code duplication - Making it easier to add new items in the future Signed-off-by: vishal <[email protected]>
- Add WSLMessage component to display information about Windows Subsystem for Linux (WSL) - Show WSLMessage only once, directly below the `Download Node.js®` title, when Windows(WIN) is selected in any OS dropdown - Refactor context usage to allow independent OS selection in each dropdown - Register WSLMessage and WindowsWSLMessage in MDX components for use in MDX files - Improve user experience by providing relevant WSL info at the right place and time - Enhanced both for Dark and Light Theme with Blue background and border and glowing theme perfectly matching the ui theme of the website ! Issue nodejs#7651 Signed-off-by: vishal <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Signed-off-by: Vishal <[email protected]>
|
Hey @avivkeller I have attached the working video of this feature, any error or features are required please let me know ! |
While working on this feature, I discovered another issue I’d like to bring to your attention:The recent website banner announcing the "May Security Release is available" currently appears only in English and does not support translation into the other 10 languages offered by the site. As a result, users browsing the site in their native languages are unable to read this important notification.
I believe it’s important that all users receive this notification in their preferred language.If you agree, I’d be happy to open a new issue to request this feature! |
|
Also, please avoid tagging specific individuals without a valid reason—just because someone reviewed a previous PR doesn’t mean they’re currently available. |
I totally not understood how .pre-commit-config.yaml gets committed and changes everytime as during the staging proccess it doesn't show mw the yaml file has changed! If you know please guide me! And here are the changes what I have done : Can you please suggest / pin a specific file so that I can clearly understood |
|
It looks like your IDE is formatting unrelated files automatically. Try using the terminal to "git add"the files you want to change. You can start by "git reset"-ing the changes to remove unrelated ones. Make sure that the pre commit hooks are running as well. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #7757 +/- ##
==========================================
+ Coverage 75.09% 75.18% +0.09%
==========================================
Files 98 98
Lines 7914 7979 +65
Branches 196 206 +10
==========================================
+ Hits 5943 5999 +56
- Misses 1970 1979 +9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR introduces a new feature to the download page:
When a user selects "Windows" as their operating system in any of the OS dropdowns, a WSL (Windows Subsystem for Linux) informational message is displayed directly below the "Download Node.js®" title.
The message provides users with helpful information about WSL and a link to learn more, improving the experience for Windows users interested in running Node.js in a Linux environment.
Key changes:
WSLMessageandWindowsWSLMessagecomponents.Validation
Working video Drive Link
Related Issues
Addresses #7651
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.