Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle event refs with no apiVersion/kind fields at all #1151

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kopf/_cogs/clients/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async def post_event(

# Prevent "event explosion", when core v1 events are handled and create other core v1 events.
# This can happen with `EVERYTHING` without additional filters, or by explicitly serving them.
if ref['apiVersion'] == 'v1' and ref['kind'] == 'Event':
if ref.get('apiVersion') == 'v1' and ref.get('kind') == 'Event':
return

# See #164. For cluster-scoped objects, use the current namespace from the current context.
Expand Down
Loading