Compare the timing to code overhead's min/max range instead of max-only #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to ensure that, if the code overhead happens to be big enough, and the actual time small enough, there is a basic check for unrealistic values: i.e. that the time taken is at least the minimum expected overhead.
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
A follow-up for #520: Ensure that the time-based tests also check for a minimum time taken.
Description
This is needed to ensure that if the code overhead happens to be big enough, and the actual time small enough, there is a basic check for unrealistic values: i.e. that the time taken is at least the minimum expected overhead.
In addition, to fight fluctuations of measurements, 10 data samples are taken. Since this takes a little bit of time, the value is cached in session, and is reused in all further tests (it does not depend on the test itself).
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt