Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin and upgrade pytest & co #535

Merged
merged 3 commits into from
Sep 6, 2020
Merged

Unpin and upgrade pytest & co #535

merged 3 commits into from
Sep 6, 2020

Conversation

nolar
Copy link
Owner

@nolar nolar commented Sep 6, 2020

What do these changes do?

Remove pinning introduced in #352.

Description

And routinely fix a few tiny issues detected during the test-runs with updated libraries.

Issues/PRs

Issues: #338

Related: #352

Type of changes

  • Mostly CI/CD automation, contribution experience

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

It was injecting `Bearer` schema even if the token is absent, and `aiohttp`
didn't like it in combination with Basic Auth (username + password). When
the token is absent, the `Authorization:` header should be absent too.
@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Sep 6, 2020
@nolar nolar changed the title Unpin upgrade pytest and co Unpin and upgrade pytest & co Sep 6, 2020
@nolar nolar merged commit 559bd9f into master Sep 6, 2020
@nolar nolar deleted the unpin-upgrade-pytest-and-co branch September 6, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant