Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minja: update submodule to fix {# hang (redo) #3457

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

cebtenzzre
Copy link
Member

Redo of #3446, but this time with Windows support.

WIP. No actual difference from that PR yet, just leaving this here to track the new changes.

@cebtenzzre cebtenzzre marked this pull request as ready for review February 4, 2025 22:25
@cebtenzzre
Copy link
Member Author

cebtenzzre commented Feb 4, 2025

I updated the fix to a version that works even on the non-conforming Microsoft STL. It was tested on Windows this time and it works as expected. Also rebased on the latest upstream.

@cebtenzzre cebtenzzre requested a review from manyoso February 4, 2025 22:28
@cebtenzzre cebtenzzre merged commit 04dc157 into main Feb 4, 2025
4 of 11 checks passed
@cebtenzzre cebtenzzre deleted the fix-minja-opencomment branch February 4, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants