File Reader | Add next_line_file_offset #8953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-add-total-lines-bytes-offset-to-file-reader
branch
2 times, most recently
from
509414c to
7587425
Compare
romayalon
changed the title
romayalon
force-pushed
the
romy-add-total-lines-bytes-offset-to-file-reader
branch
from
7587425 to
b223ddb
Compare
romayalon
force-pushed
the
romy-add-total-lines-bytes-offset-to-file-reader
branch
from
b223ddb to
2b24711
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-add-total-lines-bytes-offset-to-file-reader
branch
from
2b24711 to
2116887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
On #8923, we would like to preserve the next_line_file_offset in order to start reading in the next iteration from the middle of the file and not read the whole file again.
Moved the fileReader changes from 8923 to a new PR.
Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: