Skip to content

Add more validation for lifecycle #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tangledbytes
Copy link
Member

Describe the Problem

Right now NooBaa validates a bunch of lifecycle policy but misses on the following 2:

  1. Does not throw error if DaysAfterInitiation is empty in the AbortIncompleteMultipartUpload rule.
  2. Does not throw error if DaysAfterInitiation is 0 in the AbortIncompleteMultipartUpload rule.
  3. Does not throw error if NoncurrentDays is empty in the NoncurrentVersionExpiration rule.
  4. Does not throw error if NoncurrentDays is 0 in the NoncurrentVersionExpiration rule.

Explain the Changes

Added more rules in the put-bucket-lifecycle-configuration.

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/DFBUGS-2141

Testing Instructions:

  • Doc added/updated
  • Tests added

@tangledbytes tangledbytes force-pushed the utkarsh/fix/lifecycle-validations branch from abf3feb to e326403 Compare April 11, 2025 14:33
@tangledbytes tangledbytes requested a review from dannyzaken April 11, 2025 14:46
Signed-off-by: Utkarsh Srivastava <[email protected]>
@tangledbytes tangledbytes force-pushed the utkarsh/fix/lifecycle-validations branch from e326403 to 04b8e96 Compare April 11, 2025 15:18
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangledbytes tangledbytes merged commit 1ccdd48 into noobaa:master Apr 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants