fix: Central Server permissions #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2023 16:37
…gs tab refs: XRDDEV-2543
refs: XRDDEV-2543
refs: XRDDEV-2543
mikkbachmann
requested review from
a team,
ovidijusnortal,
enelir and
andresrosenthal
and removed request for
a team,
ovidijusnortal and
enelir
| - VIEW_EXTERNAL_CONFIGURATION_SOURCE: [ XROAD_SYSTEM_ADMINISTRATOR, XROAD_SECURITY_OFFICER ] | ||
| - GENERATE_SOURCE_ANCHOR: [ XROAD_SECURITY_OFFICER ] | ||
| - DOWNLOAD_SOURCE_ANCHOR: [ XROAD_SECURITY_OFFICER ] | ||
| - UPLOAD_CONFIGURATION_PART: [ XROAD_SECURITY_OFFICER, XROAD_REGISTRATION_OFFICER ] | ||
| - UPLOAD_CONFIGURATION_PART: [ XROAD_SECURITY_OFFICER ] |
There was a problem hiding this comment.
Seems like this line is missing XROAD_SYSTEM_ADMINISTRATOR role.
According to spec upload & download should both have XROAD_SYSTEM_ADMINISTRATOR & XROAD_SECURITY_OFFICER roles
| - ADD_MEMBER_CLASS: [ XROAD_SYSTEM_ADMINISTRATOR ] | ||
| - EDIT_MEMBER_CLASS: [ XROAD_SYSTEM_ADMINISTRATOR ] | ||
| - DELETE_MEMBER_CLASS: [ XROAD_SYSTEM_ADMINISTRATOR ] | ||
| - VIEW_MEMBER_CLASSES: [ XROAD_SECURITY_OFFICER, XROAD_SYSTEM_ADMINISTRATOR ] |
There was a problem hiding this comment.
According to spec, CRUD operations regarding member classes should be allowed to XROAD_SECURITY_OFFICER only.
added 2 commits
December 17, 2023 22:21
refs: XRDDEV-2543
refs: XRDDEV-2543
|
andresrosenthal
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fixed Security Officer permissions on the Settings tab and also made some viewing permissions more consistent between roles.
refs: XRDDEV-2543