fix: SonarCloud and Dependabot fixes #1958

ovidijusnortal · 2024-02-15T13:57:40Z

https://github.com/nordic-institute/X-Road/security/code-scanning/21

Closes: XRDDEV-2597

github-actions · 2024-02-15T14:28:31Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	❌

github-actions · 2024-02-15T15:14:36Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-19T14:55:54Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-19T14:58:34Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-19T15:49:34Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-20T09:25:23Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-21T07:36:12Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.5	✅

github-actions · 2024-02-21T10:01:57Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

github-actions · 2024-02-21T11:13:48Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

github-actions · 2024-02-21T13:49:09Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

github-actions · 2024-02-22T09:22:06Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

ricardas-buc

Overall ok, just few clarifications before merging

src/signer/src/intTest/java/org/niis/xroad/signer/test/glue/SignerStepDefs.java

...ons/metaservice/src/main/java/ee/ria/xroad/proxy/serverproxy/MetadataServiceHandlerImpl.java

https://github.com/nordic-institute/X-Road/security/code-scanning/21 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/code-scanning/25 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/code-scanning/20 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/code-scanning/22 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/code-scanning/23 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/dependabot/308 Closes: XRDDEV-2597

…eated files #292 https://github.com/nordic-institute/X-Road/security/dependabot/292 Closes: XRDDEV-2597

https://github.com/nordic-institute/X-Road/security/dependabot/297 Closes: XRDDEV-2597

Closes: XRDDEV-2597

…spath dependency overrides Closes: XRDDEV-2597

Closes: XRDDEV-2597

github-actions · 2024-02-22T14:19:28Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

…RE_PROCESSING=true Closes: XRDDEV-2597

sonarqubecloud · 2024-02-22T15:02:07Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-02-22T15:25:09Z

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
src	build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate	8.6	✅

ovidijusnortal force-pushed the XRDDEV-2597 branch from 5d5e93d to cc17cfc Compare February 20, 2024 08:45

ovidijusnortal force-pushed the XRDDEV-2597 branch from cc17cfc to 19cbcf2 Compare February 21, 2024 06:59

ovidijusnortal force-pushed the XRDDEV-2597 branch from 19cbcf2 to 42e424f Compare February 21, 2024 09:22

ovidijusnortal marked this pull request as ready for review February 21, 2024 14:44

ovidijusnortal requested a review from ricardas-buc February 21, 2024 14:44

ovidijusnortal force-pushed the XRDDEV-2597 branch from f04332b to 485272c Compare February 22, 2024 08:34

ricardas-buc approved these changes Feb 22, 2024

View reviewed changes

src/signer/src/intTest/java/org/niis/xroad/signer/test/glue/SignerStepDefs.java Show resolved Hide resolved

...ons/metaservice/src/main/java/ee/ria/xroad/proxy/serverproxy/MetadataServiceHandlerImpl.java Outdated Show resolved Hide resolved

ovidijusnortal added 12 commits February 22, 2024 15:35

fix: Logging should not be vulnerable to injection attacks

40a6b78

https://github.com/nordic-institute/X-Road/security/code-scanning/21 Closes: XRDDEV-2597

fix: Server certificates should be verified during SSL/TLS connections

2e4e992

https://github.com/nordic-institute/X-Road/security/code-scanning/25 Closes: XRDDEV-2597

fix: Weak SSL/TLS protocols should not be used

99219cf

https://github.com/nordic-institute/X-Road/security/code-scanning/20 Closes: XRDDEV-2597

fix: Extracting archives should not lead to zip slip vulnerabilities

2ba03f2

https://github.com/nordic-institute/X-Road/security/code-scanning/22 Closes: XRDDEV-2597

fix: XML parsers should not be vulnerable to XXE attacks

d63ef97

https://github.com/nordic-institute/X-Road/security/code-scanning/23 Closes: XRDDEV-2597

fix: Information Disclosure in Guava #308

fb3a827

https://github.com/nordic-institute/X-Road/security/dependabot/308 Closes: XRDDEV-2597

fix: TemporaryFolder on unix-like systems does not limit access to cr…

b658260

…eated files #292 https://github.com/nordic-institute/X-Road/security/dependabot/292 Closes: XRDDEV-2597

fix: netty-handler SniHandler 16MB allocation #297

74294d8

https://github.com/nordic-institute/X-Road/security/dependabot/297 Closes: XRDDEV-2597

fix: up bouncy castle version

a2289c1

Closes: XRDDEV-2597

fix: up gradle version and few other dependencies

06a5c13

Closes: XRDDEV-2597

fix: sonar issue

833f3df

Closes: XRDDEV-2597

fix: build issue(wrong jar names for newer dependency version)

f14aa5f

Closes: XRDDEV-2597

ovidijusnortal added 3 commits February 22, 2024 15:36

fix: small issue with CN part when creating certificates, remove clas…

e0694db

…spath dependency overrides Closes: XRDDEV-2597

fix: remove few old dependency constrains

5081866

Closes: XRDDEV-2597

fix: post rebase issue fixes

09d92e7

Closes: XRDDEV-2597

ovidijusnortal force-pushed the XRDDEV-2597 branch from 485272c to 09d92e7 Compare February 22, 2024 13:36

fix: security concerns should be covered by XMLConstants.FEATURE_SECU…

a846ed7

…RE_PROCESSING=true Closes: XRDDEV-2597

ovidijusnortal merged commit 6b0ea5d into develop Feb 23, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: SonarCloud and Dependabot fixes #1958

fix: SonarCloud and Dependabot fixes #1958

ovidijusnortal commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 15, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 20, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 22, 2024

X-Road tests :: BuildAndPackageWithUnitTests

ricardas-buc left a comment

github-actions bot commented Feb 22, 2024

X-Road tests :: BuildAndPackageWithUnitTests

sonarqubecloud bot commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024

X-Road tests :: BuildAndPackageWithUnitTests

fix: SonarCloud and Dependabot fixes #1958

fix: SonarCloud and Dependabot fixes #1958

Conversation

ovidijusnortal commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 15, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 19, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 20, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 21, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

github-actions bot commented Feb 22, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

ricardas-buc left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

sonarqubecloud bot commented Feb 22, 2024 • edited Loading

Quality Gate passed

github-actions bot commented Feb 22, 2024

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests

sonarqubecloud bot commented Feb 22, 2024 •

edited

Loading