style: added swag item's popup & desc #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Seek4samurai is attempting to deploy a commit to the Novu Team on Vercel. A member of the Team first needs to authorize it. |
|
Kindly go through the PR. |
|
Thank you! added a small comment! |
nevo-david
reviewed
Oct 6, 2022
| const desc = [ | ||
| { | ||
| id: '0', | ||
| desc: 'Get the best fit for you and your team! Hacksquad T-shirts for all the coolest contributors.', |
There was a problem hiding this comment.
Add also the image path here, and then we can just run over this array to display the picture
bsantosh909
suggested changes
Oct 11, 2022
| </p> | ||
|
|
||
| <ul className="grid-gap relative mt-20 grid grid-cols-4 md:mt-16 sm:mt-10 sm:grid-cols-2"> | ||
| {swagList.map((item, index) => ( |
There was a problem hiding this comment.
Instead of going over the swagList array and using index to fetch items, you might want to add the image in the desc array file itself and just iterate over that array.
In that way you won't have to import image in different file and also you want have to rely on index position to get title and description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes.