Revert "fix(node): add includeInactiveChannels option in sdk method (#…

…7115)" This reverts commit 4a715e4.
novuhq · Nov 29, 2024 · 4dd144d · 4dd144d
1 parent 4a715e4
commit 4dd144d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 37 deletions.
diff --git a/packages/node/README.md b/packages/node/README.md
@@ -337,22 +337,12 @@ await novu.subscribers.updateOnlineStatus('subscriberId', false);
 
 - #### Get subscriber preference for all workflows
 
-This method returns subscriber preference for all workflows with inactive channels by default. To get subscriber preference for all workflows without inactive (means only active) channels, pass `false` as second argument.
-
 ```ts
 import { Novu } from '@novu/node';
 
 const novu = new Novu('<NOVU_SECRET_KEY>');
 
-// return subscriber preference for all workflows without inactive channels
-await novu.subscribers.getPreference('subscriberId', {
-  includeInactiveChannels: false,
-});
-
-// return subscriber preference for all workflows with inactive channels
-await novu.subscribers.getPreference('subscriberId', {
-  includeInactiveChannels: true,
-});
+await novu.subscribers.getPreference('subscriberId');
 ```
 
 - #### Get subscriber global preference
@@ -766,23 +756,13 @@ await novu.messages.list(params);
 - #### Delete a message by `messageId`
 
 ```ts
-import { Novu } from '@novu/node';
+import { Novu, ChannelTypeEnum } from '@novu/node';
 
 const novu = new Novu('<NOVU_SECRET_KEY>');
 
 await novu.messages.deleteById('messageId');
 ```
 
-- #### Delete multiple messages by `transactionId`
-
-```ts
-import { Novu } from '@novu/node';
-
-const novu = new Novu('<NOVU_SECRET_KEY>');
-
-await novu.messages.deleteByTransactionId('transactionId');
-```
-
 ### Layouts
 
 - #### Create a layout

diff --git a/packages/node/src/lib/subscribers/subscriber.interface.ts b/packages/node/src/lib/subscribers/subscriber.interface.ts
@@ -34,10 +34,7 @@ export interface ISubscribers {
    */
   unsetCredentials(subscriberId: string, providerId: string);
   updateOnlineStatus(subscriberId: string, online: boolean);
-  getPreference(
-    subscriberId: string,
-    { includeInactiveChannels }: { includeInactiveChannels: boolean },
-  );
+  getPreference(subscriberId: string);
   getGlobalPreference(subscriberId: string);
   getPreferenceByLevel(subscriberId: string, level: PreferenceLevelEnum);
   updatePreference(

diff --git a/packages/node/src/lib/subscribers/subscribers.spec.ts b/packages/node/src/lib/subscribers/subscribers.spec.ts
@@ -193,13 +193,11 @@ describe('test use of novus node package - Subscribers class', () => {
   test('should get subscriber preference', async () => {
     mockedAxios.get.mockResolvedValue({});
 
-    await novu.subscribers.getPreference('test-subscriber-preference', {
-      includeInactiveChannels: true,
-    });
+    await novu.subscribers.getPreference('test-subscriber-preference');
 
     expect(mockedAxios.get).toHaveBeenCalled();
     expect(mockedAxios.get).toHaveBeenCalledWith(
-      '/subscribers/test-subscriber-preference/preferences?includeInactiveChannels=true',
+      '/subscribers/test-subscriber-preference/preferences',
     );
   });
 

diff --git a/packages/node/src/lib/subscribers/subscribers.ts b/packages/node/src/lib/subscribers/subscribers.ts
@@ -91,13 +91,8 @@ export class Subscribers extends WithHttp implements ISubscribers {
     return await this.http.delete(`/subscribers/${subscriberId}`);
   }
 
-  async getPreference(
-    subscriberId: string,
-    { includeInactiveChannels = true }: { includeInactiveChannels: boolean },
-  ) {
-    return await this.http.get(
-      `/subscribers/${subscriberId}/preferences?includeInactiveChannels=${includeInactiveChannels}`,
-    );
+  async getPreference(subscriberId: string) {
+    return await this.http.get(`/subscribers/${subscriberId}/preferences`);
   }
 
   async getGlobalPreference(subscriberId: string) {