-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): step naming #7140
fix(api): step naming #7140
Conversation
# Conflicts: # apps/api/src/app/workflows-v2/usecases/sync-to-environment/sync-to-environment.usecase.ts
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@djabarovgeorge Defining the IdentifierOrInternalId type as a string doesn't add any value, so let's just drop it. Moreover, this PR is about alignment. So the naming should be the same between workflows and steps. That is |
apps/api/src/app/workflows-v2/usecases/build-step-data/build-step-data.command.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview.usecase.ts
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the feedback! @SokratisVidros |
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer