feat(api): wip fix framework workflow issues #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
commented
Nov 27, 2024
Comment on lines
+169
to
191
| const validatedWorkflowWithIssues = await this.workflowUpdatePostProcess.execute({ | ||
| user: { | ||
| _id: command.userId, | ||
| environmentId: command.environmentId, | ||
| organizationId: command.organizationId, | ||
| } as UserSessionData, | ||
| workflow: { | ||
| ...savedWorkflow, | ||
| userPreferences: null, | ||
| defaultPreferences: this.getWorkflowPreferences(workflow), | ||
| }, | ||
| }); | ||
|
|
||
| savedWorkflow = await this.updateWorkflowUsecase.execute( | ||
| UpdateWorkflowCommand.create({ | ||
| ...validatedWorkflowWithIssues, | ||
| id: validatedWorkflowWithIssues._id, | ||
| type: WorkflowTypeEnum.BRIDGE, | ||
| environmentId: command.environmentId, | ||
| organizationId: command.organizationId, | ||
| userId: command.userId, | ||
| }) | ||
| ); |
There was a problem hiding this comment.
this part is responsible for updating the issues on the workflow
djabarovgeorge
commented
Nov 27, 2024
Comment on lines
178
to
180
| if (children === PreviewIssueEnum.PREVIEW_ISSUE_REQUIRED_CONTROL_VALUE_IS_MISSING) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
this part ensures that the issue returned by the API from the backend is not rendered.
https://www.loom.com/share/ae23d0ef53ff455a8f5fe5b521674308
I have two questions:
- Is this the correct approach to render null it in the new dashboard?
- Why are we returning this value from the backend in the first place? Don’t we already use issues to inform the frontend when there’s a problem?
There was a problem hiding this comment.
My main problem with it, is that the preview will not indicate any error state on the tab. This at least shows you that something is wrong.
@novu/client
@novu/headless
@novu/framework
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
…rkflows-show-preview-issuerequired-control-value-is # Conflicts: # apps/api/src/app/workflows-v2/generate-preview.e2e.ts
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
scopsy
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Looks good, let's just restore the issue rendering behaviour as per the slack thread https://github.com/novuhq/novu/pull/7147/files#r1865851863
…rkflows-show-preview-issuerequired-control-value-is
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
deleted the
nv-4813-code-first-workflows-show-preview-issuerequired-control-value-is
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
now framework workflow has issues ;)
https://www.loom.com/share/ae23d0ef53ff455a8f5fe5b521674308
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer