feat(api-service): Nv 5304 update pricing and billing pages #7718

tatarco · 2025-02-13T15:29:40Z

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

linear · 2025-02-13T15:29:43Z

NV-5304 Update Pricing and Billing pages

netlify · 2025-02-13T15:29:58Z

❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name	Link
🔨 Latest commit	`1d18922`
🔍 Latest deploy log	https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67b767348368d90008244b52

netlify · 2025-02-13T15:30:02Z

✅ Deploy Preview for dev-web-novu ready!

Name	Link
🔨 Latest commit	`1d18922`
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/67b76734132d9c0008a101e1
😎 Deploy Preview	https://deploy-preview-7718.dashboard.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ChmaraX

Please fix the spellcheck errors as well.

Also, we need to change this dashboard part as well:
https://github.com/novuhq/novu/blob/bfb8b9517dd4d8342c0f9850974fb226882ec10c/apps/web/src/ee/billing/components/PlanActionButton.tsx

The action button to "Upgrade plan" has a hardcoded http call like this:

...
api.post(checkoutUrl, {
  billingInterval: selectedBillingInterval,
  apiServiceLevel: ApiServiceLevelEnum.BUSINESS,
}),
...

The apiServiceLevel on the button need to change dynamically based on selected plan.

apps/api/src/app/billing/e2e/checkout-session-completed.e2e-ee.ts

apps/api/src/app/billing/e2e/create-subscription.e2e-ee.ts

apps/api/src/app/environments-v1/usecases/create-environment/create-environment.usecase.ts

apps/api/src/app/environments-v1/usecases/create-environment/validate-tiers-use.case.ts

libs/dal/src/repositories/organization/community.organization.repository.ts

.source

SokratisVidros · 2025-02-18T15:17:02Z

apps/api/src/app/environments-v1/usecases/create-environment/create-environment.usecase.ts

@@ -27,9 +27,6 @@ export class CreateEnvironment {
      _organizationId: command.organizationId,
    });

-    if (environmentCount >= 10) {


I am not quite sure how do we enforce the environment creation limit after this change.

it's done with a decorator on the controller, we said the number is irrelevant it's a Yes / No Question, the create + delete enpooints are blocked if the tier decides so

apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts

apps/dashboard/README.md

apps/dashboard/src/components/billing/plan-action-button.tsx

.../api/src/app/workflows-v2/usecases/service-level-tier-validator/tier-validation-type.enum.ts

apps/api/src/app/workflows-v2/usecases/service-level-tier-validator/validate-tiers-use.case.ts

SokratisVidros · 2025-02-18T15:40:04Z

apps/dashboard/src/components/billing/highlights-row.tsx

+};
+
+function augmentBasedOfFeatureFlags(highlightsArray: Partial<PlanHighlights>, featureFlags: FeatureFlags) {
+  if (!featureFlags[FeatureFlagsKeysEnum.IS_2025_Q1_TIERING_ENABLED]) {


Consider using the useFeatureFlag to read the feature flad to avoid introducing a new pattern on feature flag consumption.

I cannot use this function locally, it has to propegate between function, in such case I prefer to create code that doesn't have to be deleted completly, that's why I introduced a new pattern, the feature flags can be there propagated and if needed to make augmentations they can be done there

apps/api/src/app/workflows-v2/usecases/service-level-tier-validator/index.ts

apps/api/src/app/workflows-v2/usecases/service-level-tier-validator/tier-exceeded.exception.ts

SokratisVidros · 2025-02-18T15:50:46Z

packages/shared/src/consts/feature-tiers-constants.ts

@@ -0,0 +1,678 @@
+import { ApiServiceLevelEnum, FeatureFlags, FeatureFlagsKeysEnum } from '../types';
+
+export enum FeatureNameEnum {


Enlisting all features of the product in a enum in shared along with presentational concerns feels convoluted a this point. I suggest modelling only the features that are different per plan and affect the business logic and the execution. The rest are just static values for the pricing page.

The best way to think about it is do the exercise of putting the features that differ per plan in Stripe metadata. We will do the clean up right after this PR. In that case we wouldn't add all of these from shared to Stripe. We would only add the things that change per plan.

I recognize the effort of putting everything in one place but the result is more convoluted than the complexity of our pricing model at this point.

Even features in stripe should be populated from a single source of truth, that's the attempt to create it, you don't want this pricelist to exist partially in 6 locations, it makes the maintenance extremely uncomfortable, the point here it to make the next time much easier

apps/api/src/app/billing/e2e/checkout-session-completed.e2e-ee.ts

github-actions bot added @novu/web @novu/dal @novu/shared @novu/worker @novu/dashboard @novu/api-service labels Feb 13, 2025

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from e764002 to ea985f6 Compare February 13, 2025 15:30

tatarco temporarily deployed to Linting February 13, 2025 15:30 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 13, 2025 15:30 — with GitHub Actions Failure

tatarco temporarily deployed to Linting February 13, 2025 15:30 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 13, 2025 15:33 — with GitHub Actions Failure

tatarco temporarily deployed to Linting February 13, 2025 15:33 — with GitHub Actions Inactive

tatarco changed the title ~~Nv 5304 update pricing and billing pages~~ feat(api-service): Nv 5304 update pricing and billing pages Feb 13, 2025

ChmaraX requested changes Feb 13, 2025

View reviewed changes

ChmaraX requested a review from SokratisVidros February 13, 2025 15:57

ChmaraX assigned LetItRock and unassigned LetItRock Feb 13, 2025

ChmaraX requested a review from LetItRock February 13, 2025 15:57

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from 9d4d26f to 814ffb7 Compare February 17, 2025 05:33

tatarco temporarily deployed to Linting February 17, 2025 05:33 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 17, 2025 05:33 — with GitHub Actions Failure

tatarco temporarily deployed to Linting February 17, 2025 05:33 — with GitHub Actions Inactive

tatarco temporarily deployed to Linting February 17, 2025 06:40 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 17, 2025 06:40 — with GitHub Actions Failure

github-actions bot removed the @novu/dal label Feb 17, 2025

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from c1eb199 to 4a1cd50 Compare February 18, 2025 06:17

tatarco temporarily deployed to Linting February 18, 2025 06:17 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 18, 2025 06:17 — with GitHub Actions Failure

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from 17fe776 to 53f9a99 Compare February 18, 2025 12:07

djabarovgeorge reviewed Feb 18, 2025

View reviewed changes

.source Outdated Show resolved Hide resolved

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from 53f9a99 to 330ddad Compare February 18, 2025 14:11

tatarco temporarily deployed to Linting February 18, 2025 14:11 — with GitHub Actions Inactive

tatarco had a problem deploying to Linting February 18, 2025 14:11 — with GitHub Actions Failure

djabarovgeorge temporarily deployed to Linting February 18, 2025 15:43 — with GitHub Actions Inactive

djabarovgeorge had a problem deploying to Linting February 18, 2025 15:43 — with GitHub Actions Failure

djabarovgeorge temporarily deployed to Linting February 18, 2025 15:43 — with GitHub Actions Inactive

SokratisVidros requested changes Feb 18, 2025

View reviewed changes

ChmaraX reviewed Feb 18, 2025

View reviewed changes

apps/api/src/app/billing/e2e/checkout-session-completed.e2e-ee.ts Show resolved Hide resolved

tatarco temporarily deployed to Linting February 19, 2025 07:16 — with GitHub Actions Inactive

tatarco temporarily deployed to Linting February 20, 2025 17:30 — with GitHub Actions Inactive

tatarco and others added 5 commits February 20, 2025 18:31

2631d2a96321a3e8d2b3f249cbdada1c7df43160

c21f185

fix(root): deps

1867d95

PR comments

ac29004

PR comments

bd3c59f

PR comments

1d18922

tatarco force-pushed the nv-5304-update-pricing-and-billing-pages branch from d226632 to 1d18922 Compare February 20, 2025 17:32

tatarco temporarily deployed to Linting February 20, 2025 17:32 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api-service): Nv 5304 update pricing and billing pages #7718

feat(api-service): Nv 5304 update pricing and billing pages #7718

tatarco commented Feb 13, 2025

linear bot commented Feb 13, 2025

netlify bot commented Feb 13, 2025 •

edited

Loading

netlify bot commented Feb 13, 2025 •

edited

Loading

ChmaraX left a comment

SokratisVidros Feb 18, 2025 •

edited

Loading

tatarco Feb 19, 2025

SokratisVidros Feb 18, 2025

tatarco Feb 19, 2025

SokratisVidros Feb 18, 2025

tatarco Feb 19, 2025

		@@ -0,0 +1,678 @@
		import { ApiServiceLevelEnum, FeatureFlags, FeatureFlagsKeysEnum } from '../types';

		export enum FeatureNameEnum {

feat(api-service): Nv 5304 update pricing and billing pages #7718

Are you sure you want to change the base?

feat(api-service): Nv 5304 update pricing and billing pages #7718

Conversation

tatarco commented Feb 13, 2025

What changed? Why was the change needed?

Screenshots

Related enterprise PR

Special notes for your reviewer

linear bot commented Feb 13, 2025

netlify bot commented Feb 13, 2025 • edited Loading

❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

netlify bot commented Feb 13, 2025 • edited Loading

✅ Deploy Preview for dev-web-novu ready!

ChmaraX left a comment

Choose a reason for hiding this comment

SokratisVidros Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

tatarco Feb 19, 2025

Choose a reason for hiding this comment

SokratisVidros Feb 18, 2025

Choose a reason for hiding this comment

tatarco Feb 19, 2025

Choose a reason for hiding this comment

SokratisVidros Feb 18, 2025

Choose a reason for hiding this comment

tatarco Feb 19, 2025

Choose a reason for hiding this comment

netlify bot commented Feb 13, 2025 •

edited

Loading

netlify bot commented Feb 13, 2025 •

edited

Loading

SokratisVidros Feb 18, 2025 •

edited

Loading