Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New detector: EtaLikeSimplifications #198

Merged
merged 17 commits into from
Nov 4, 2024
Merged

New detector: EtaLikeSimplifications #198

merged 17 commits into from
Nov 4, 2024

Conversation

Esorat
Copy link
Member

@Esorat Esorat commented Oct 24, 2024 •
edited
Loading

Closes #92

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented
  • No test failures were reported when running yarn test-all
  • I did not do unrelated and/or undiscussed refactorings

@jubnzv jubnzv changed the title Detector etaLikeSimplifications New detector: EtaLikeSimplifications Oct 24, 2024
@jubnzv jubnzv marked this pull request as draft October 24, 2024 13:01
jubnzv
jubnzv requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core logic seems correct. Let's adjust the implementation.

src/detectors/builtin/etaLikeSimplifications.ts Outdated Show resolved Hide resolved
src/detectors/builtin/etaLikeSimplifications.ts Outdated Show resolved Hide resolved
src/detectors/builtin/etaLikeSimplifications.ts Outdated Show resolved Hide resolved
src/detectors/builtin/etaLikeSimplifications.ts Outdated Show resolved Hide resolved
src/detectors/builtin/etaLikeSimplifications.ts Outdated Show resolved Hide resolved
@jubnzv
Copy link
Member

jubnzv commented Nov 1, 2024 •
edited
Loading

We should also merge master in your branch and resolve conflicts, including those in the changelog.

@Esorat Esorat marked this pull request as ready for review November 2, 2024 15:57
jubnzv
jubnzv approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@jubnzv jubnzv merged commit e894231 into nowarp:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv jubnzv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect eta-like simplifications
2 participants
@Esorat @jubnzv