-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable operators #115
Merged
Merged
Pluggable operators #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
@Kuniwak san, please review if you have time 🙇 |
This comment has been minimized.
This comment has been minimized.
This is just a thought. Since IOperator has an IsMatch method (and I think CanOperate would be a more intuitive name, as per the comments), I wondered if it might not be necessary for Component to have something like CanClick. |
Kuniwak
reviewed
Apr 9, 2024
Code Metrics Report
Details | | master (2b8260c) | #115 (490a770) | +/- |
|---------------------|------------------|----------------|-------|
+ | Coverage | 71.6% | 71.8% | +0.2% |
| Files | 31 | 31 | 0 |
| Lines | 694 | 705 | +11 |
+ | Covered | 497 | 506 | +9 |
+ | Code to Test Ratio | 1:1.1 | 1:1.1 | +0.0 |
| Code | 1494 | 1540 | +46 |
+ | Test | 1643 | 1720 | +77 |
+ | Test Execution Time | 4m30s | 4m26s | -4s | Code coverage of files in pull request scope (85.9% → 85.8%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement pluggable Operators. The Operator includes a matcher and operating method.
When you want to perform special operations on a particular Component or GameObject, or when UI elements do not support uGUI, you can define a corresponding operator.
fixed #54
Changes
IOperator
interfaceUGUIClickOperator
,UGUIClickAndHoldOperator
,UGUITextInputOperator
MonkeyConfig
TouchAndHoldDelayMillis
,RandomString
, andRandomStringParametersStrategy
to operatorsIsReachable
strategy method includes ScreenPointStrategy. So remove GetScreenPoint function from MonkeyConfigTODO