add npm cache npx command and fix stale-version reuse in npx
#8100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
commented
Feb 11, 2025
wraithgar
changed the title
npm cache npx command and fix stale-version reuse in npxnpm cache npx command and fix stale-version reuse in npx
|
We are going to be rebase/merging this so I have renamed this PR to NOT be a conventional message, that way our linter will warn us about commits that don't pass conventional commit linting. |
wraithgar
reviewed
Feb 11, 2025
owlstronaut
commented
Feb 11, 2025
owlstronaut
commented
Feb 12, 2025
| @@ -53,7 +55,8 @@ const missingFromTree = async ({ spec, tree, flatOptions, isNpxTree, shallow }) | |||
| return { node } | |||
| } | |||
| // package requested by version range, only remaining registry type | |||
| if (semver.satisfies(node.package.version, spec.rawSpec)) { | |||
| // the npx tree shouldn't be ok w/ an outdated version | |||
| if (!isNpxTree && semver.satisfies(node.package.version, spec.rawSpec)) { | |||
There was a problem hiding this comment.
@wraithgar I'm going to need help getting to this codepath in the unit tests, haven't been able to pull the right strings
There was a problem hiding this comment.
we need a version of the package that is in the npx cache that is older than the latest version as specified by the requested range.
So: [email protected] in the cache, npx pkg@1 is requested, [email protected] exists. It should prompt/update to 1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References