Only break within words in codes
#1489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal words shouldn't break at random places.
Peeja
requested review from
leobalter,
monishcm and
wraithgar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #802, these
lis were set toword-break: break-all, causing any word that's unfortunate enough to find itself at the end of a line to break at any arbitrary character. This was done to keep long words incodeelements, like "git+https://example.com/foo/bar#115311855adb0789a0466714ed48a1499ffea97e", from overflowing the line box and the right margin. But we only want that behavior forcodes, not for all text in theli.Screenshots
Before
https://docs.npmjs.com/package-name-guidelines
https://docs.npmjs.com/cli/v11/configuring-npm/package-lock-json
After
https://docs.npmjs.com/package-name-guidelines
https://docs.npmjs.com/cli/v11/configuring-npm/package-lock-json
References
Related to #802