This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
Added support for github redirects #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2016 10:09
Bumped github package version Fixed method names that changed since the old github version
Moved enterprise-configurator to a dev dependency because it's not actually deployed in npme but is needed to run tests
|
@briansneddon appreciate the patch 👍 we will get this merged and tested next time we rollout the npm Enterprise docker containers. |
|
@briansneddon Apologies for the delay, I plan on taking a closer look at this tomorrow, hopefully getting it merged and released. (I think this fixes #27?) Thanks for contributing! |
|
We faced this problem today after a user renamed a Github repo and did not change the value |
|
@briansneddon thanks for the patch! sorry this took so long to land; will work on getting this out the door with a couple other authentication changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When github projects are moved and a redirect left behind authorization breaks because github library 0.2.4 doesn't support redirects and just returns the redirect object which has no permissions attribute (needed by subsequently called _handleGithubResponse.
The latest github library 3.1.1 does support redirects so the response for github.repos.get will include the permissions attribute.