net: lib: nrf_cloud: misc improvements

[plskeggs]

Add missing support for NRF_CLOUD_TOPIC_STATE_TF. This should have been done for the MQTT JSONata Transform feature added a while back (unrelated to the gateway).

Fix uninitialized variable issue in in_last_job() in nrf_cloud_fota.c.

Remove most of the conditionals for the gateway, but add one to fix up topic suffix.

[NordicBuilder]

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: afdeab1e21885a48850ad94c82919e75b6176014

more details

sdk-nrf:

PR head: afdeab1e21885a48850ad94c82919e75b6176014
merge base: bde6b19b00b74b47ce37a09f75e815064a0d4827
target head (main): 5e55cf8835f364acbc8d23da446b575957ac859a
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

include
│  ├── net
│  │  │ nrf_cloud.h
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── include
│  │  │  │  │  │ nrf_cloud_codec_internal.h
│  │  │  │  ├── src
│  │  │  │  │  ├── nrf_cloud.c
│  │  │  │  │  ├── nrf_cloud_codec_internal.c
│  │  │  │  │  ├── nrf_cloud_fota.c
│  │  │  │  │  │ nrf_cloud_transport.c

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

• ◻️ Toolchain - Skipped: existing toolchain is used
• ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 1
• ✅ Integration tests
  • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
  • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
  • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
  • ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
  • ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
  • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
  • ⚠️ test-fw-nrfconnect-fw-update
  • ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Disabled integration tests

• • desktop52_verification
  • doc-internal
  • test-fw-nrfconnect-apps
  • test-fw-nrfconnect-ble_mesh
  • test-fw-nrfconnect-ble_samples
  • test-fw-nrfconnect-chip
  • test-fw-nrfconnect-fem
  • test-fw-nrfconnect-nfc
  • test-fw-nrfconnect-nrf-iot_libmodem-nrf
  • test-fw-nrfconnect-nrf-iot_lwm2m
  • test-fw-nrfconnect-nrf-iot_samples
  • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
  • test-fw-nrfconnect-nrf_crypto
  • test-fw-nrfconnect-proprietary_esb
  • test-fw-nrfconnect-ps
  • test-fw-nrfconnect-rpc
  • test-fw-nrfconnect-rs
  • test-fw-nrfconnect-tfm
  • test-fw-nrfconnect-thread
  • test-fw-nrfconnect-zigbee
  • test-low-level
  • test-sdk-audio
  • test-sdk-dfu
  • test-sdk-find-my
  • test-sdk-pmic-samples
  • test-sdk-sidewalk
  • test-sdk-wifi
  • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

You can find the documentation preview for this PR here.

[plskeggs]

@pascal-nordic @maxd-nordic please consider approving. Thanks!