Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Hover previews #1390

Open
wants to merge 24 commits into
base: release53
Choose a base branch
from

Conversation

mint-dewit
Copy link
Contributor

@mint-dewit mint-dewit commented Feb 25, 2025

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Feature

Current Behavior

  • The design for hover previews is many years old and not been revised
  • Any piece can only show a hover preview for the type of source layer that it is on

New Behavior

  • Update design for better consistency
  • Allow blueprints to override the hover preview for any piece (i.e. detach the hover preview from source layer type)
  • Hover previews can be opened from anywhere that has the context available
  • Previews have the option to either track the mouse or be displayed in a static position

Affected areas

This PR only affects the frontend code. (Except for some additional types in blueprints integration)

Time Frame

Other Information

  • Some files for development (HTML pages and video file) as well as an option to point all VT hover previews to aforementioned video file have been included
  • This PR has been based on initial work from NRK but I have not added any of the interactive elements, leaving that up to NRK to implement

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Sorry, something went wrong.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 56.82%. Comparing base (eee202a) to head (1cda4a8).
Report is 51 commits behind head on release53.

Files with missing lines Patch % Lines
...ns/pieceContentStatusUI/checkPieceContentStatus.ts 9.52% 19 Missing ⚠️
packages/corelib/src/lib.ts 20.00% 4 Missing ⚠️
meteor/server/api/rest/v1/typeConversion.ts 0.00% 2 Missing ⚠️
meteor/server/lib/rest/v1/studios.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release53    #1390      +/-   ##
=============================================
+ Coverage      56.27%   56.82%   +0.54%     
=============================================
  Files            408      402       -6     
  Lines          73118    72968     -150     
  Branches        4189     4463     +274     
=============================================
+ Hits           41148    41464     +316     
+ Misses         31843    31363     -480     
- Partials         127      141      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mint-dewit mint-dewit force-pushed the feat/contribute-preview-popup branch from 6278a13 to 1cda4a8 Compare March 20, 2025 08:51
@mint-dewit mint-dewit marked this pull request as ready for review March 20, 2025 08:51
@mint-dewit mint-dewit requested a review from a team as a code owner March 20, 2025 08:51
@jstarpl jstarpl changed the title Refactor Hover Previews feat: new Hover previews Mar 20, 2025
@jstarpl jstarpl added the Contribution External contribution label Mar 20, 2025
@jstarpl jstarpl added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants