Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ab notifications and logging #1401

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

The AB notifications that were added in #1303 have been reworded to be more descriptive. Instead of a notification saying Failed to assign players for {{count}} sessions, a notification will be raised per failed session, which lists the pieces that requested the failed session Failed to assign AB player for {{pieceNames}}

Additionally the console logging for the ab logic has been improved to always include the sessionName as defined by blueprints. This is to make it easier to debug ab sessions for blueprint developers.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner March 10, 2025 14:29
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 60.97561% with 32 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (95b1187) to head (e054aaa).
Report is 165 commits behind head on release53.

Files with missing lines Patch % Lines
...ackages/job-worker/src/playout/abPlayback/index.ts 4.34% 22 Missing ⚠️
...-worker/src/playout/abPlayback/applyAssignments.ts 71.42% 8 Missing ⚠️
...orker/src/playout/abPlayback/abPlaybackSessions.ts 88.88% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release53    #1401      +/-   ##
=============================================
- Coverage      56.90%   56.26%   -0.65%     
=============================================
  Files            383      408      +25     
  Lines          71530    73140    +1610     
  Branches        4253     4598     +345     
=============================================
+ Hits           40706    41151     +445     
- Misses         30690    31734    +1044     
- Partials         134      255     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarpl jstarpl added Contribution External contribution Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Mar 20, 2025
@nytamin nytamin merged commit aa2a5e0 into nrkno:release53 Apr 1, 2025
33 of 34 checks passed
@Julusian Julusian deleted the upstream/improve-ab-logging branch April 1, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants