Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: time of day pieces #1406

Draft
wants to merge 2 commits into
base: release53
Choose a base branch
from

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

This builds on top of #1384

Time of day pieces are a new concept, where a rundown is able to define some pieces that should play at an absolute timestamp, no matter what part is active at the time.
This could be utilised to show some graphic about what is next, or to ensure that the outro is triggered at the correct time (doing so out of vision) to ensure it will be at the right point when the show reaches the end time.

These pieces can be returned from the getRundown blueprint method, and are very similar to pieces returned as part of a part. A few properties which are not relevant are removed, and the enable property must contain isAbsolute: true. This change allows the system to not need much special handling for them, with many of the differences based off this different start rule.

During playout, these pieces will be omitted from the timeline until ~30s before their start time. This duration is controlled by a new studio setting. Only once this point has been crossed will the pieces be considered for AB and lookahead. Sofie&playout-gateway coordinate regenerating the timeline at this 30s threshold, make sure to be running playout-gateway. (#1384 was written for this)

Other than that, these behave pretty much like normal outOnRundownChange pieces. They show in the ui in the current part, and in future parts once playback of the piece has started. They can be stopped/cleared by other pieces with the same rules as normal, and can be updated through the syncIngestChanges flow as usual.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian changed the title feat: add object to timeline to trigger a regeneration at point in time feat: time of day pieces Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (4d991aa) to head (1044d93).
Report is 17 commits behind head on release53.

Files with missing lines Patch % Lines
packages/corelib/src/playout/infinites.ts 63.33% 11 Missing ⚠️
packages/corelib/src/playout/processAndPrune.ts 94.59% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release53    #1406       +/-   ##
==============================================
+ Coverage      56.68%   74.82%   +18.14%     
==============================================
  Files            397       32      -365     
  Lines          72391     4759    -67632     
  Branches        4391      544     -3847     
==============================================
- Hits           41032     3561    -37471     
+ Misses         31253     1193    -30060     
+ Partials         106        5      -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant