fix: don't hide global adlibs from hidden sourceLayers

[Julusian]

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix / feature

New Behavior

Global Adlibs on hidden sourcelayers will now be shown in the shelf.
Prior to this they were able to get hotkeys assigned, but they wouldn't be listed.

Blueprints can instead set the hidden property on the adlibs to hide them (still getting hotkeys)

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (eee202a) to head (4396665).
Report is 51 commits behind head on release53.

Additional details and impacted files

@@              Coverage Diff              @@
##           release53    #1409      +/-   ##
=============================================
+ Coverage      56.27%   56.83%   +0.56%     
=============================================
  Files            408      402       -6     
  Lines          73118    72939     -179     
  Branches        4189     4439     +250     
=============================================
+ Hits           41148    41456     +308     
+ Misses         31843    31335     -508     
- Partials         127      148      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.