fix: reimplement removePartInstance flow for syncChangesToPartInstances

[jstarpl]

Note

This is a rebase of the PR for release53 of #1408

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

This is a regression believed to be introduced by #1035

The removePartInstance method on SyncIngestUpdateToPartInstanceContext is broken, it did not reset the PartInstance correctly.

This PR reimplements this for the new model approach.

As part of this, some refactoring was done first, to make it easier to unit test portions of this logic. Not many tests have been added as part of this, but tests have been added for removePartInstance.

I have not looked into backporting this fix to earlier releases, but I suspect it would be pretty straightforward to rebase it without the refactoring or unit tests.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 85.67073% with 47 lines in your changes missing coverage. Please review.

Project coverage is 56.57%. Comparing base (b2d584e) to head (17106c7).
Report is 11 commits behind head on release52.

Files with missing lines	Patch %	Lines
...job-worker/src/ingest/syncChangesToPartInstance.ts	85.89%	45 Missing ⚠️
...s/context/SyncIngestUpdateToPartInstanceContext.ts	77.77%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1410      +/-   ##
=============================================
+ Coverage      56.25%   56.57%   +0.32%     
=============================================
  Files            408      408              
  Lines          73125    73255     +130     
  Branches        4625     4665      +40     
=============================================
+ Hits           41133    41445     +312     
+ Misses         31901    31591     -310     
- Partials          91      219     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.